Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent poisioning mResTable if Framework is sparse. #3299

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversation

iBotPeaches
Copy link
Owner

@iBotPeaches iBotPeaches commented Aug 27, 2023

We have a leaking issue where we populate mApkInfo during each decode, which may be n (each framework). These values are all stored in 1 location. We can prevent setting the sparse flag if we've already loaded the main packages (pkgs within resources.arsc).

fixes: #3298

@iBotPeaches iBotPeaches marked this pull request as ready for review August 27, 2023 18:44
@iBotPeaches iBotPeaches merged commit 81a7e1e into master Aug 27, 2023
31 checks passed
@iBotPeaches iBotPeaches deleted the issue-3298 branch August 27, 2023 19:06
@iBotPeaches iBotPeaches added this to the v2.9.0 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] mResTable poisoned if framework is sparse
1 participant