Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: verbose doesn't adapt handler #3310

Merged
merged 1 commit into from Sep 3, 2023
Merged

refactor: verbose doesn't adapt handler #3310

merged 1 commit into from Sep 3, 2023

Conversation

iBotPeaches
Copy link
Owner

This has become way too verbose. I can't even easily grep what I want. Dumping method names just isn't helpful - the helpful log messages that are emitted during verbose is all we need.

prior:

Sep 03, 2023 6:19:55 AM brut.androlib.ApkDecoder decode
INFO: Using Apktool v2.8.1-54-06c5f462-SNAPSHOT on Kate.apk
Sep 03, 2023 6:19:55 AM brut.androlib.res.data.ResTable loadMainPkg
INFO: Loading resource table...
Sep 03, 2023 6:19:55 AM brut.androlib.res.decoder.ARSCDecoder readResourceTable
FINE: Chunk #1 start: type=0x0002 chunkSize=0x0010ca40

now:

I: Using Apktool v2.8.1-54-06c5f462-SNAPSHOT on Kate.apk
I: Loading resource table...
F: Chunk #1 start: type=0x0002 chunkSize=0x0010ca40

@iBotPeaches iBotPeaches merged commit dcb6788 into master Sep 3, 2023
31 checks passed
@iBotPeaches iBotPeaches deleted the refactor-verbose-mode branch September 3, 2023 11:06
iBotPeaches added a commit that referenced this pull request Sep 3, 2023
@iBotPeaches
docs: adjust changelog for #3310
430de4b
@iBotPeaches iBotPeaches added this to the v2.9.0 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@iBotPeaches