Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy link icon #321

Merged
merged 2 commits into from Oct 13, 2021
Merged

Add copy link icon #321

merged 2 commits into from Oct 13, 2021

Conversation

a26620236
Copy link
Contributor

Purpose

Changes

  • a list of what have been done
  • maybe some code change

Risk

Usually none, if you have any please write it here.

TODOs

  • Describe what should be done outside of this PR
  • Maybe in other PRs or some manual actions.

</g>
<defs>
<clipPath id="copy-link_svg__clip0">
<path fill="#fff" transform="translate(8 8)" d="M0 0h16v16H0z" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這裡有個白色好像漏掉了,要檢查一下

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以先手動改掉就是

Suggested change
<path fill="#fff" transform="translate(8 8)" d="M0 0h16v16H0z" />
<path fill="#transparent" transform="translate(8 8)" d="M0 0h16v16H0z" />

Copy link
Contributor

@zhusee2 zhusee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他 LGTM

</g>
<defs>
<clipPath id="copy-link_svg__clip0">
<path fill="#fff" transform="translate(8 8)" d="M0 0h16v16H0z" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以先手動改掉就是

Suggested change
<path fill="#fff" transform="translate(8 8)" d="M0 0h16v16H0z" />
<path fill="#transparent" transform="translate(8 8)" d="M0 0h16v16H0z" />

@a26620236 a26620236 merged commit 11740cc into develop Oct 13, 2021
@a26620236 a26620236 deleted the feature/add_new_icon branch October 13, 2021 04:20
@zhusee2 zhusee2 restored the feature/add_new_icon branch October 19, 2021 08:59
@zhusee2 zhusee2 deleted the feature/add_new_icon branch October 19, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants