Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gypcrete] upgrade react to v17 #405

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Conversation

kyoyadmoon
Copy link
Member

@kyoyadmoon kyoyadmoon commented Jun 2, 2023

Purpose

升級 react 到 v17

Changes

  • 升級 react 和相關的套件到 v17
  • 更換 enzyme adapter
  • 將 legacy lifecycle 加上 UNSAFE prefix
  • 發現有測試因更新壞掉,主要是沒做好 unmount 的清理,加上後就修復了

@github-actions github-actions bot temporarily deployed to canary June 2, 2023 07:17 Inactive
@github-actions github-actions bot temporarily deployed to canary June 2, 2023 07:27 Inactive
@github-actions github-actions bot temporarily deployed to canary June 2, 2023 07:29 Inactive
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #405 (ae627a9) into develop (00d4997) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #405   +/-   ##
========================================
  Coverage    88.43%   88.43%           
========================================
  Files          151      151           
  Lines         1539     1539           
  Branches       281      281           
========================================
  Hits          1361     1361           
  Misses         178      178           
Impacted Files Coverage Δ
configs/jestSetup.js 100.00% <ø> (ø)
packages/core/src/EditableBasicRow.js 100.00% <100.00%> (ø)
packages/core/src/EditableTextLabel.js 100.00% <100.00%> (ø)
packages/core/src/StatusIcon.js 100.00% <100.00%> (ø)
packages/core/src/mixins/closable.js 100.00% <100.00%> (ø)
packages/form/src/SelectList.js 98.83% <100.00%> (ø)
packages/form/src/SelectRow.js 98.71% <100.00%> (ø)
packages/form/src/SwitchRow.js 100.00% <100.00%> (ø)
packages/imageeditor/src/ImageEditor.js 98.18% <100.00%> (ø)

Copy link
Contributor

@chenesan chenesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@leannechen leannechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot temporarily deployed to canary June 13, 2023 02:48 Inactive
@kyoyadmoon kyoyadmoon merged commit e9afbeb into develop Jun 26, 2023
11 checks passed
@kyoyadmoon kyoyadmoon deleted the feat/upgrade-react-to-v17 branch June 26, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants