Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react to v17 - resolve packages not match react 17 #406

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Upgrade react to v17 - resolve packages not match react 17 #406

merged 2 commits into from
Jun 26, 2023

Conversation

kyoyadmoon
Copy link
Member

@kyoyadmoon kyoyadmoon commented Jun 13, 2023 •
edited
Loading

Purpose

  • Fix react version not match warnings when install packages

Changes

  • upgrade react-textarea-autosize from v7 to v8
  • replace create-react-context with native React Context API

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kyoyadmoon kyoyadmoon changed the title Feat/resolve-packages-not-match-react-17 Upgrade react to v17 - resolve packages not match react 17 Jun 13, 2023
@github-actions github-actions bot temporarily deployed to canary June 13, 2023 03:59 Inactive
@kyoyadmoon kyoyadmoon marked this pull request as ready for review June 13, 2023 04:03
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #406 (39b825c) into feat/upgrade-react-to-v17 (ae627a9) will not change coverage.
The diff coverage is 100.00%.

@@                    Coverage Diff                     @@
##           feat/upgrade-react-to-v17     #406   +/-   ##
==========================================================
  Coverage                      88.43%   88.43%           
==========================================================
  Files                            151      151           
  Lines                           1539     1539           
  Branches                         281      281           
==========================================================
  Hits                            1361     1361           
  Misses                           178      178
Impacted Files Coverage Δ
packages/core/src/contexts/listSpacing.js 100.00% <100.00%> (ø)

Base automatically changed from feat/upgrade-react-to-v17 to develop June 26, 2023 09:26
@kyoyadmoon kyoyadmoon merged commit 981ec5a into develop Jun 26, 2023
8 checks passed
@kyoyadmoon kyoyadmoon deleted the feat/resolve-packages-not-match-react-17 branch June 26, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenesan chenesan chenesan approved these changes

@Orcus2021 Orcus2021 Orcus2021 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyoyadmoon @chenesan @Orcus2021