Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade React to v18 #420

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

kyoyadmoon
Copy link
Member

@kyoyadmoon kyoyadmoon commented Dec 18, 2023

Purpose

  • 將 React 升級到 v18
  • React 相關套件升級到支援 React 18
  • ReactDOM 的 API 變動 migrate
  • 將原本 enzyme 測試的 ReactDOM.render 換成 testing-library 的 render,因為 ReactDOM.render 在 React 18 已經被棄用了

整體變動的檔案數量較多,建議依照 commit review

Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #420 (c2d9b9e) into refactor/remove-unsafe-lifecycles-part4 (9fefd36) will increase coverage by 0.18%.
The diff coverage is n/a.

Additional details and impacted files
@@                             Coverage Diff                             @@
##           refactor/remove-unsafe-lifecycles-part4     #420      +/-   ##
===========================================================================
+ Coverage                                    88.20%   88.38%   +0.18%     
===========================================================================
  Files                                          151      151              
  Lines                                         1602     1601       -1     
  Branches                                       278      278              
===========================================================================
+ Hits                                          1413     1415       +2     
+ Misses                                         189      186       -3     

see 4 files with indirect coverage changes

@kyoyadmoon kyoyadmoon changed the title docs: Refactor ReactDOM.render to use createRoot feat: upgrade React to v18 Dec 18, 2023
@kyoyadmoon kyoyadmoon marked this pull request as ready for review December 18, 2023 07:06
Base automatically changed from refactor/remove-unsafe-lifecycles-part4 to project/upgrade-react-v18 December 19, 2023 10:15
@kyoyadmoon kyoyadmoon merged commit a3439b8 into project/upgrade-react-v18 Dec 19, 2023
7 checks passed
@kyoyadmoon kyoyadmoon deleted the feat/upgrade-react-v18 branch December 19, 2023 10:15
@zhusee2 zhusee2 added this to the v7 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants