Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Nextjs to 13.4.12 #1849

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Update Nextjs to 13.4.12 #1849

merged 4 commits into from
Aug 1, 2023

Conversation

danielcliu-ifixit
Copy link
Member

@danielcliu-ifixit danielcliu-ifixit commented Jul 26, 2023 •
edited by federicobadini
Loading

Overview

As recommended to try to fix this error lets update next js to the lastest version. This just upgrades patches so everything should be backwards compatible, meaning no code changes should be necessary on our end.

QA

Does everything still seem fine?

CC @federicobadini @danielbeardsley @sterlinghirsh
Connects: #1808
Closes: #1852

danielcliu-ifixit
danielcliu-ifixit commented Jul 26, 2023
View reviewed changes
pnpm-lock.yaml Outdated Show resolved Hide resolved
danielcliu-ifixit
danielcliu-ifixit commented Jul 26, 2023
View reviewed changes
pnpm-lock.yaml Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jul 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 7:10pm
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 7:10pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 363.79 KB (🟡 +12.14 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@danielcliu-ifixit
Copy link
Member Author

deploy_block ✌️ on me restructuring the commits and such

@federicobadini
Copy link
Contributor

federicobadini commented Jul 27, 2023 •
edited
Loading

CR 👍
The changes to the lockfile are driven by pnpm itself, seems nothing critical.
By the way this should also fix this: vercel/next.js#49789.
Not sure why this is not present in Sentry but this error is easily reproducible via BrowserStack

@federicobadini federicobadini mentioned this pull request Jul 27, 2023
Closed
@vercel vercel bot temporarily deployed to Preview – react-commerce-prod July 27, 2023 19:39 Inactive
@danielcliu-ifixit danielcliu-ifixit force-pushed the update-next-13-patches branch 2 times, most recently from a7cd71c to 9f30bbf Compare July 27, 2023 19:50
@danielcliu-ifixit
Copy link
Member Author

sorry about the commit mess.

Looked over the changes for @sentry/nextjs didn't see anything worrying but we should keep an eye on the error logs when this deploys

@danielcliu-ifixit
Copy link
Member Author

forgot to un_deploy_block ✌️

@danielbeardsley
Copy link
Member

By the way this should also fix this: vercel/next.js#49789.

which prevents any client-side code from running.

Ooof.

The Safari 12-13 version range accounts for ~0.5% of our traffic and revenue. Google Analytics doesn't show the revenue dropping off a cliff, so I'm not sure we were affected.

@deltuh-vee deltuh-vee self-assigned this Jul 31, 2023
@deltuh-vee deltuh-vee added the QAing Under QA team review label Jul 31, 2023
@deltuh-vee
Copy link
Contributor

QA 🎬
react-commerce pages are still working.

@deltuh-vee deltuh-vee removed the QAing Under QA team review label Jul 31, 2023
@danielcliu-ifixit
Copy link
Member Author

QA 🌵 carry-over

aburke07
aburke07 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@aburke07 aburke07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👽

@danielcliu-ifixit danielcliu-ifixit merged commit e907074 into main Aug 1, 2023
15 checks passed
@danielcliu-ifixit danielcliu-ifixit deleted the update-next-13-patches branch August 1, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburke07 aburke07 aburke07 approved these changes

Assignees

@deltuh-vee deltuh-vee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find variable: BigInt
5 participants
@danielcliu-ifixit @federicobadini @danielbeardsley @deltuh-vee @aburke07