Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve product list item pricing #274

Merged
merged 3 commits into from May 5, 2022
Merged

Improve product list item pricing #274

merged 3 commits into from May 5, 2022

Conversation

dhmacs
Copy link
Contributor

@dhmacs dhmacs commented May 4, 2022

fixes #259

Changelog

  • If customer is a pro, use the normal price as the compare_at_price if compare_at_price is null in the Algolia index.

QA

  1. Visit the Vercel PR preview (replace vercel.app with cominor.com)
  2. Visit the tools product list (/Store/Tools)
  3. Verify that a pro user sees the normal price as a compare at price when a product has a discounted price for the user tier

@vercel
Copy link

vercel bot commented May 4, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-commerce ✅ Ready (Inspect) Visit Preview May 4, 2022 at 8:46PM (UTC)

masonmcelvain
masonmcelvain approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@masonmcelvain masonmcelvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✌🏻

@danielbeardsley
Copy link
Member

CR 👍

Looks good @dhmacs !

deploy_block 👍 on considering a few suggestions.

@danielbeardsley
Copy link
Member

CR 👍

@jordycosta
Copy link
Member

jordycosta commented May 4, 2022 •
edited

dev_block 🟥

Preview 404'ing on both Parts/Tools

404

@dhmacs
Copy link
Contributor Author

dhmacs commented May 4, 2022

@jordycosta Strapi was down. I've restarted it un_dev_block 🟢

masonmcelvain
masonmcelvain approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@masonmcelvain masonmcelvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✌🏻

@dhmacs
Copy link
Contributor Author

dhmacs commented May 5, 2022

un_deploy_block 🚀

@jordycosta jordycosta self-assigned this May 5, 2022
@jordycosta
Copy link
Member

QA 🟢

Discounted products now display price comparisons to the original pricing for appropriate user tiers ✔️

Testing Procedure:

  1. Navigate to the Vercel preview
  2. Click on Tools
  3. Scroll down the product list until you see a discounted item
  4. Ensure that the price comparison and percent off % tag is being displayed

There are some discounts provided for all user tier(s), which is expected

Screen Captures:

pricing
discount

@danielbeardsley danielbeardsley merged commit 976e726 into main May 5, 2022
@dhmacs dhmacs deleted the improve-product-list-item-pricing branch May 5, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbeardsley danielbeardsley danielbeardsley left review comments

@masonmcelvain masonmcelvain masonmcelvain approved these changes

Assignees

@jordycosta jordycosta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve how pricing is shown
4 participants
@dhmacs @danielbeardsley @jordycosta @masonmcelvain