Update Click to version 7.1.2 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for my ignorance, I should've just checked the Travis config. 😂 Nose tests are passing on Travis. |
|
Ah, thanks for the PR! I don't think bumping the dependency should cause any problems, so I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't quite get the tests to run correctly for this PR (tried both
pytestandunittest) but after upgradingclickto 7.1.2, EulerPy seems to work fine on my machine.This is probably a necessary change to resolve common dependency conflicts (ex. when installing
black) and I'm sure at least a few others have experienced an issue or two due to this.This project doesn't appear to be maintained much anymore, but I'm hoping you might see this @iKevinY.