Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the number of possible detector layers to 40 #11

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

Zehvogel
Copy link
Contributor

For some detectors (e.g. CLD) 20 is not enough when using the DDCEDViewer. The remaining magically can still be drawn but then not be toggled on/off. Therefore I naively doubled this to be able to handle 40 detector parts in the hopes that it will be good enough for the foreseeable future.

I tested this locally and it looks like nothing broke, but who knows with this code...

BEGINRELEASENOTES

  • Increased the number of possible detector layers to 40

ENDRELEASENOTES

@Zehvogel
Copy link
Contributor Author

can anyone take a look at this? maybe @tmadlener (I don't know if you are also responsible for this repo :D)

@andresailer
Copy link
Contributor

@Zehvogel Could you update the CI jobs to the recent ones, like in iLCSoft/MarlinReco#128 ?

Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I am wondering whether there is something more clever to be done about the displaying stuff.

.github/workflows/linux.yml Outdated Show resolved Hide resolved
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
@Zehvogel
Copy link
Contributor Author

I am wondering whether there is something more clever to be done about the displaying stuff.

Probably yes, but I don't have the time for more effort than this 🤷

Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solves a problem now and I would not know who could look into this in more depth at the moment, so we take it as it is.

@tmadlener tmadlener merged commit cc537ca into iLCSoft:master Mar 27, 2024
8 checks passed
@Zehvogel Zehvogel deleted the layers branch March 27, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants