Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding clang-format to cmake #11

Merged
merged 5 commits into from Jun 13, 2017
Merged

Adding clang-format to cmake #11

merged 5 commits into from Jun 13, 2017

Conversation

dhynds
Copy link
Contributor

@dhynds dhynds commented Jun 8, 2017

BEGINRELEASENOTES

  • Added clang-format to cmake lists and added extra target. "make format" will now format the code, and will be prepared automatically if clang-format exists.
  • Updated tracking strategy and added some improvements in terms of refitting tracks each time a hit is added, and included a maximum chi2 criteria for adding hits

ENDRELEASENOTES

@andresailer
Copy link
Contributor

If you just want the clang format in the PR, please drop the other commits, otherwise change the first PR comment to include other changes.
Also: please don't add the UNDEBUG flag permanently. And maybe use some different DEBUG levels and not just a single one

@dhynds
Copy link
Contributor Author

dhynds commented Jun 13, 2017

Ok, removed the commit for forced debug. Added comments in the release notes.

@andresailer andresailer self-requested a review June 13, 2017 14:24
@andresailer andresailer merged commit a1c032c into iLCSoft:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants