New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust energy loss parameterisation (Bethe-Bloch etc) #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted ! We seem to have used the wrong formula for > 15 years ;-(
Did you make any checks on on how big the effect is ?
I assume it is rather small...
it's the difference between green and red at high beta-gamma: Actually, I am looking at the small beta-gamma region, where we currently use the red curve, which gets very incorrect below around 10^(-1.5), but that's a story for a future pull request! |
commit ba574d7 (curves for orig dedx code ; with the density term bug fixed; and with Ziegler at low beta-gamma) also similarly for K in Ar gas: current BB param gives negative dedx for beta-gam < ~few 10-2 |
Hi @danieljeans, could you rebase this onto the current master branch to pick up the new CI configuration? |
@tmadlener : rebased |
Thanks a lot. Looks like the tests also passed (as expected). Is there anything from the physics side still blocking this for inclusion in the upcoming developers release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We clearly want this to go in - and then study the effect w/ the developers release...
BEGINRELEASENOTES
ENDRELEASENOTES