Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust energy loss parameterisation (Bethe-Bloch etc) #13

Merged
merged 3 commits into from Jun 24, 2022

Conversation

danieljeans
Copy link

@danieljeans danieljeans commented Apr 25, 2022

BEGINRELEASENOTES

    • add missing factor 0.5 to density term of Bethe-Bloch parameterisation
      ENDRELEASENOTES

Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted ! We seem to have used the wrong formula for > 15 years ;-(
Did you make any checks on on how big the effect is ?
I assume it is rather small...

@danieljeans
Copy link
Author

Well spotted ! We seem to have used the wrong formula for > 15 years ;-( Did you make any checks on on how big the effect is ? I assume it is rather small...

it's the difference between green and red at high beta-gamma:
compare.pdf
I suspect it has a rather small effect. including the 1/2 factor brings red onto green.

Actually, I am looking at the small beta-gamma region, where we currently use the red curve, which gets very incorrect below around 10^(-1.5), but that's a story for a future pull request!

@danieljeans danieljeans changed the title fix density correction (delta term) in Bethe-Bloch adjust energy loss parameterisation (Bethe-Bloch etc) Jun 1, 2022
@danieljeans
Copy link
Author

danieljeans commented Jun 1, 2022

commit ba574d7
implements the "Ziegler" parametrisation of energy loss, used when beta-gamma<0.1.
Essentially copied/adapted from G4 code.
Resulting dedx curves for muons in Fe are shown here:
compare_BB_Zieg.pdf

(curves for orig dedx code ; with the density term bug fixed; and with Ziegler at low beta-gamma)

also similarly for K in Ar gas:
compare_BB_Zieg_KAr.pdf

current BB param gives negative dedx for beta-gam < ~few 10-2

@tmadlener
Copy link
Contributor

Hi @danieljeans, could you rebase this onto the current master branch to pick up the new CI configuration?

@danieljeans
Copy link
Author

@tmadlener : rebased

@tmadlener
Copy link
Contributor

Thanks a lot. Looks like the tests also passed (as expected). Is there anything from the physics side still blocking this for inclusion in the upcoming developers release?

Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We clearly want this to go in - and then study the effect w/ the developers release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants