Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect CMAKE_INSTALL_<dir> #13

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Respect CMAKE_INSTALL_<dir> #13

merged 4 commits into from
Aug 15, 2023

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Jul 17, 2023 •
edited
Loading

BEGINRELEASENOTES

  • Respect CMAKE_INSTALL_

ENDRELEASENOTES

@jmcarcell jmcarcell changed the title Respect CMAKE_INSTALL_<dir> and don't put libraries in lib64 Respect CMAKE_INSTALL_<dir> Jul 28, 2023
@jmcarcell
Copy link
Contributor Author

This has now been changed to only respect CMAKE_INSTALL_<dir> which is a non controversial change

tmadlener
tmadlener approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need changes in iLCInstall. Opening a separate issue for keeping track of that later.

@tmadlener tmadlener merged commit 44de4a7 into iLCSoft:master Aug 15, 2023
3 of 4 checks passed
@tmadlener tmadlener mentioned this pull request Aug 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmcarcell @tmadlener