Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove overwriting of input parameters in TVSurface::CalcXingPointWith #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove overwriting of input parameters in TVSurface::CalcXingPointWith #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cae651
remove overwriting of input parameters in TVSurface::CalcXingPointWith
danieljeans Nov 29, 2022
726bf9d
change default eps to 1e-5 (to match previously hardcoded value)
danieljeans Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/geomlib/TVSurface.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,10 @@ Int_t TVSurface::CalcXingPointWith(const TVTrack &hel,
Int_t mode,
Double_t eps) const
{
eps = 1.e-5;

// eps = 1.e-5; // do we really want to ignore the input value?
// this Newtonian method is used for non-uniform b field,
// for this case mode is currently set to 0
mode = 0;
// mode = 0; // do we really want to ignore the input value?

static const Int_t maxcount = 100;
static const Double_t initlambda = 1.e-10;
Expand Down
4 changes: 2 additions & 2 deletions src/geomlib/TVSurface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ class TVSurface : public TObject {
virtual Int_t CalcXingPointWith(const TVTrack &hel,
TVector3 &xx,
Double_t &phi,
Double_t eps = 1.e-8) const;
Double_t eps = 1.e-5) const;
virtual Int_t CalcXingPointWith(const TVTrack &hel,
TVector3 &xx,
Double_t &phi,
Int_t mode,
Double_t eps = 1.e-8) const;
Double_t eps = 1.e-5) const;

virtual Double_t CalcS (const TVector3 &xx) const = 0;
virtual TMatrixD CalcDSDx (const TVector3 &xx) const = 0;
Expand Down