Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation warnings #8

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Fix compilation warnings #8

merged 3 commits into from
Aug 16, 2023

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Jul 30, 2023 •
edited
Loading

BEGINRELEASENOTES

  • Fix compilation warnings

ENDRELEASENOTES

All trivial ones except the std::unary_function which I changed to a simple if since it's only used once and the if is simpler

tmadlener
tmadlener reviewed Aug 15, 2023
View reviewed changes
source/src/lccd.cc Outdated Show resolved Hide resolved
@tmadlener
Copy link
Contributor

Does this fix all warnings? Then we could add -Werror to CI.

@jmcarcell
Copy link
Contributor Author

jmcarcell commented Aug 15, 2023 •
edited
Loading

Yes, all warnings are fixed for me (gcc 13.2.1)

tmadlener
tmadlener approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tmadlener tmadlener merged commit 1d907e9 into iLCSoft:master Aug 16, 2023
3 of 4 checks passed
@jmcarcell jmcarcell deleted the warnings branch November 26, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmcarcell @tmadlener