Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sio via git submodules #179

Closed
tmadlener opened this issue Nov 27, 2023 · 1 comment · Fixed by #181
Closed

Use sio via git submodules #179

tmadlener opened this issue Nov 27, 2023 · 1 comment · Fixed by #181

Comments

@tmadlener
Copy link
Contributor

Keeping the sio sources here and in the upstream repo in sync is potentially more work than it needs to be and it might be easier to fix issues like #178 in upstream and then directly pick them up here if SIO would be included as a git submodule here.

@arummler
Copy link
Contributor

arummler commented Dec 3, 2023

I would propose to avoid submodules; better to use FetchContent. Mixing git and cmake methods otherwise quickly becomes tricky. Particularly for downstream consumers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants