Adding substructure variables #10

lstroem · 2018-05-04T14:05:10Z

BEGINRELEASENOTES

Implemented substructure parameters commonly used for top tagging. The definition of these new variables can be adjusted from the steering file (added options to steer how to calculate the energy correlation function (energyCorrelator) and how to calculate NSubjettiness (axesMode and measureMode). Only recommended options are implemented. The beta parameter would typically be the same as used for jet clustering but can also be varied separately (beta weights the angular distances between the jet constituents compared to their pt in the calculation of the energy correlation function and subjettiness).
The substructure variables are added to the file as a collection "TopTaggerSubStructure" of seven elements (order: C2, D2, C3, D3, tau1, tau2, tau3).
This update is backwards compatible, with the only difference being the addition of this collection.

ENDRELEASENOTES

lstroem · 2018-05-04T14:48:39Z

*DONE - Currently adding option to name the output collection from the steering file
*DONE - Adding also a bool to activate substructure variables or not (default will be false, i.e. nothing new added)

andresailer · 2018-05-08T14:15:12Z

include/FastJetTopTagger.h

@@ -17,15 +17,37 @@
 #include <IMPL/LCCollectionVec.h>
 #include <EVENT/ReconstructedParticle.h>
 #include "IMPL/LCCollectionVec.h"
+#include <IMPL/ReconstructedParticleImpl.h>


Please sort the includes. LCCollectionVec.h is already there, twice. (please remove the one with quotes)

andresailer · 2018-05-08T14:18:49Z

src/FastJetTopTagger.cpp

+
+  //Substructure parameters
+  registerProcessorParameter("beta",
+			     "Beta is called angular exponent and weights the angular distances between the jet constituents compated to their pt in the calculation of the energy correlation function and subjettiness.",


compated --> compared?

andresailer · 2018-05-08T14:23:05Z

src/FastJetTopTagger.cpp

+    double tau2 = nSubJettiness2(*it); lcgSubStructureTau2->setDoubleVal(index, tau2);
+    double tau3 = nSubJettiness3(*it); lcgSubStructureTau3->setDoubleVal(index, tau3);
+
+    //John-Hopkins top tagger


Johns-Hopkins

andresailer · 2018-05-08T14:24:57Z

src/FastJetTopTagger.cpp

@@ -286,6 +362,22 @@ void FastJetTopTagger::processEvent(LCEvent * evt){

 } //end processEvent

+double FastJetTopTagger::getECF(PseudoJet& jet, int whichECF, double beta, std::string energyCorrelator){


pass the energyCorrelator as constant reference (std::string const& energ...), to avoid making copies of the object every time the function is called.

andresailer · 2018-05-08T14:26:40Z

include/FastJetTopTagger.h

+#include "fastjet/contrib/EnergyCorrelator.hh"
+
+#include <iomanip>
+#include <stdlib.h>


Do you need all these includes?

no, cleaned up

andresailer · 2018-05-08T14:46:53Z

src/FastJetTopTagger.cpp

+  if(!jet.has_constituents())
+    return -1.0;
+
+  EnergyCorrelator ECF(whichECF, beta, _energyCorrMap[energyCorrelator]);


The objects can be instantiated once, and then used, instead of creating one every time the function is called

petricm · 2018-05-08T14:49:01Z

include/FastJetTopTagger.h


-//Forward declaration
+using namespace fastjet;
+using namespace fastjet::contrib;


Remove using namespace from header file

lstroem · 2018-05-15T07:18:39Z

Will add support for VLC algorithm in determination of substructure variables

gaede · 2018-05-22T09:09:54Z

@lstroem @andresailer Hi, this breaks our nightly builds with:

[ 75%] Building CXX object CMakeFiles/MarlinFastJet.dir/src/FastJetTopTagger.cpp.o
In file included from /scratch/nbuilds/gcc49/2018-05-21/MarlinFastJet/HEAD/src/FastJetTopTagger.cpp:13:0:
/scratch/nbuilds/gcc49/2018-05-21/MarlinFastJet/HEAD/./include/VLCAxes.h:3:45: fatal error: fastjet/contrib/AxesDefinition.hh: No such file or directory
#include <fastjet/contrib/AxesDefinition.hh>

Which version and configuration of fastjet is required for this to work ?

petricm · 2018-05-22T09:11:58Z

This was tested in the CI with 3.2.1

lstroem · 2018-05-22T09:12:35Z

Hi Frank, I was using: /cvmfs/clicdp.cern.ch/software/FastJet/3.2.1/x86_64-slc6-gcc62-opt from /cvmfs/clicdp.cern.ch/iLCSoft/builds/2017-05-30/x86_64-slc6-gcc62-opt/init_ilcsoft.sh /Rickard

…

On 22 May 2018, at 11:09, Frank Gaede ***@***.***> wrote: @lstroem <https://github.com/lstroem> @andresailer <https://github.com/andresailer> Hi, this breaks our nightly builds with: [ 75%] Building CXX object CMakeFiles/MarlinFastJet.dir/src/FastJetTopTagger.cpp.o In file included from /scratch/nbuilds/gcc49/2018-05-21/MarlinFastJet/HEAD/src/FastJetTopTagger.cpp:13:0: /scratch/nbuilds/gcc49/2018-05-21/MarlinFastJet/HEAD/./include/VLCAxes.h:3:45: fatal error: fastjet/contrib/AxesDefinition.hh: No such file or directory #include <fastjet/contrib/AxesDefinition.hh> Which version and configuration of fastjet is required for this to work ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUr0FOQB5iblhzAHTS4Rxhh1-D7pOAyVks5t09XlgaJpZM4TytQ5>.

petricm · 2018-05-22T09:19:48Z

As this is a contrib thing, did you build FastJetContrib with Nsubjettiness?

gaede · 2018-05-22T09:24:48Z

I don't know - we built it with the standard ilcsoft install script and:

ilcsoft.install( FastJet( FastJet_version ))
ilcsoft.module("FastJet").fjcontrib_version="1.017"

Which script did you use to build it ?

petricm · 2018-05-22T09:35:04Z

I think contrib 1.017 is too old (released 2015-05-05), and approx 3 year ago this was added to Nsubjettiness

https://fastjet.hepforge.org/trac/browser/contrib/contribs/Nsubjettiness/trunk

Why are you mixing fastjet 3.2.0 (released 2016-03-17) with fastjet-contrib 1.017(released 2015-05-05)? Did you maybe forget to bump the contrib version when updating the fastjet version? As 3.2.0 would go with 1.022 (which has AxesDefinition.hh).

We don't use iLCSoft to install external packages, they are provided independently.

gaede · 2018-05-22T09:47:27Z

Indeed, this is a bug in our script - in the versions file we have:

FastJet_version = "3.2.0"
FastJetcontrib_version = "1.024"

but then ignore the contrib version...
I can't find 'valid' combinations of FastJet and contrib versions on their website - which contrib versions did you use for your installations of FastJet (3.2.1, 3.2.2 and 3.3.0 ) ?

petricm · 2018-05-22T09:57:19Z

Indeed there is no "valid" pairing of the two, the releases are usually "quite" together

3.2.0 17 March 2016
1.022 30 March 2016

but then patches are fairly random. We use 3.2.1+1.025 since the release is from 11/2016.

gaede · 2018-05-22T09:59:29Z

Ok, thanks. Will then also use 3.2.1+1.025, to be compatible (and rely on the testing you've already done with this).

Adding substructure variables

0dbe636

lstroem changed the title ~~Adding substructure variables~~ [WIP] Adding substructure variables May 8, 2018

andresailer reviewed May 8, 2018

View reviewed changes

petricm reviewed May 8, 2018

View reviewed changes

Implementing todos and comments

d2ad3e2

Adding support for VLC axes

f05b5e6

lstroem changed the title ~~[WIP] Adding substructure variables~~ Adding substructure variables May 15, 2018

Adding include file for VLCAxes

f883781

andresailer approved these changes May 18, 2018

View reviewed changes

andresailer merged commit 7a71692 into iLCSoft:master May 18, 2018

petricm mentioned this pull request May 22, 2018

missing fastjet header file "AxesDefinition.hh" #11

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding substructure variables #10

Adding substructure variables #10

lstroem commented May 4, 2018 •

edited

lstroem commented May 4, 2018 •

edited

andresailer May 8, 2018

lstroem May 14, 2018

andresailer May 8, 2018

lstroem May 14, 2018

andresailer May 8, 2018

lstroem May 14, 2018

andresailer May 8, 2018

lstroem May 14, 2018

andresailer May 8, 2018

lstroem May 14, 2018

andresailer May 8, 2018

lstroem May 14, 2018

petricm May 8, 2018

lstroem May 14, 2018

lstroem commented May 15, 2018 •

edited

gaede commented May 22, 2018

petricm commented May 22, 2018

lstroem commented May 22, 2018 via email

petricm commented May 22, 2018

gaede commented May 22, 2018

petricm commented May 22, 2018

gaede commented May 22, 2018

petricm commented May 22, 2018

gaede commented May 22, 2018

		@@ -286,6 +362,22 @@ void FastJetTopTagger::processEvent(LCEvent * evt){

		} //end processEvent

		double FastJetTopTagger::getECF(PseudoJet& jet, int whichECF, double beta, std::string energyCorrelator){

Adding substructure variables #10

Adding substructure variables #10

Conversation

lstroem commented May 4, 2018 • edited

lstroem commented May 4, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lstroem commented May 15, 2018 • edited

gaede commented May 22, 2018

petricm commented May 22, 2018

lstroem commented May 22, 2018 via email

petricm commented May 22, 2018

gaede commented May 22, 2018

petricm commented May 22, 2018

gaede commented May 22, 2018

petricm commented May 22, 2018

gaede commented May 22, 2018

lstroem commented May 4, 2018 •

edited

lstroem commented May 4, 2018 •

edited

lstroem commented May 15, 2018 •

edited