Lots of new goodies to WeightedPoints3D + a bug fix. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header-file has been re-organised and heavily commented - should work as a manual. Bug fix: a missing factor of two in propagateValErrors , the errors on the eigen-values (= the error on the estimated variances) New public methods: getElipsoid_r1 (_r2, _r3) getElipsoid_r1Error (_r2, _r3) getElipsoid_r_ave * getElipsoid_r_forw (_back) getElipsoid_vol getElipsoid_density getLongitudinalElipsis_eccentricity getTransverseElipsis_eccentricity * getMaxDist * getElipsoid_FractionInside Transformations: TransformPointToEigenSyst * TransformToEigenSyst * TransformAlongDirection (2 versions) (The ones with a * in front are only useful with Reco-input, since they need to have access to the CaloHits) getters of transformed properties: * get_x_trans (_y_, _z_) * get_COG_trans * get_COGCov_trans * get_th_ref * get_ph_ref * get_xyz_ref New private methods: findMaxDist findFirstAndLast findElipsoid_FractionInside Symbols defined: _one_sigma, _CL90, _CL95, _CL99
tmadlener
reviewed
Aug 18, 2022
There was a problem hiding this comment.
The main question I have is the one about the seeming out-of-bounds access (see below). I am not sure what is the expected behavior there, so I can't really judge whether the current implementation makes sense.
The constexpr static auto thing can be done easily via the web interface.
tmadlener
reviewed
Aug 29, 2022
tmadlener
approved these changes
Aug 29, 2022
|
@MikaelBerggren you mentioned test processors today for these changes. Could they be added to iLCSoft somewhere where appropriate, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
The header-file has been re-organised and heavily
commented - should work as a manual.
Bug fix: a missing factor of two in propagateValErrors , the errors
on the eigen-values (= the error on the estimated variances)
New public methods:
getElipsoid_r1 (_r2, _r3)
getElipsoid_r1Error (_r2, _r3)
getElipsoid_r_ave
getElipsoid_vol
getElipsoid_density
getLongitudinalElipsis_eccentricity
getTransverseElipsis_eccentricity
Transformations:
TransformPointToEigenSyst
(The ones with a * in front are only useful with Reco-input, since
they need to have access to the CaloHits)
getters of transformed properties:
New private methods:
findMaxDist
findFirstAndLast
findElipsoid_FractionInside
Symbols defined: _one_sigma, _CL90, _CL95, _CL99
ENDRELEASENOTES