Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templatize HelixClass to remove code duplication between float and double implemenations #30

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Templatize HelixClass to remove code duplication between float and double implemenations #30

merged 3 commits into from
Oct 19, 2022

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Sep 19, 2022 •
edited
Loading

BEGINRELEASENOTES

  • Introduce a HelixClassT template class and make HelixClass and HellixClass_double typedefs of this class, instead of having two separate (but practically identical) implementations that are in place currently.
    • Explicitly instantiate both versions that were in place previously to make sure things don't break downstream.
    • Mark getters as const

ENDRELEASENOTES

See #29 (comment) and #24

@tmadlener tmadlener merged commit eda5bc0 into iLCSoft:master Oct 19, 2022
@tmadlener tmadlener mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
HelixClass revision
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tmadlener