Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ILD SEcal05_ECRing for filling dd4hep::rec::LayeredCalorimeterData. #160

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Fix ILD SEcal05_ECRing for filling dd4hep::rec::LayeredCalorimeterData. #160

merged 1 commit into from
Sep 6, 2017

Conversation

shaojunlu
Copy link
Contributor

BEGINRELEASENOTES

  • Fix ILD SEcal05_ECRing for filling dd4hep::rec::LayeredCalorimeterData.
    • For the reconstruction, we fill the LayeredCalorimeterData at runtime.
    • Both side ECRings have identical layer structure, fill the one from module_num==0, and used for both.

ENDRELEASENOTES

@shaojunlu
Copy link
Contributor Author

shaojunlu commented Sep 6, 2017 •
edited
Loading

@danieljeans @rete @gaede
Dear Daniel and Remi, please validate the LayeredCalorimeterData for SEcal05_ECRing in ILD_l4_v02.
To fix issue #158

@shaojunlu shaojunlu mentioned this pull request Sep 6, 2017
Closed
@rete
Copy link
Contributor

rete commented Sep 6, 2017

Result of dumpdetector command and gear file conversion looks ok.
Ok on my side !

@gaede gaede merged commit 7179f49 into key4hep:master Sep 6, 2017
@shaojunlu shaojunlu deleted the FixILDECRing branch September 7, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rete rete rete approved these changes

@gaede gaede gaede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaojunlu @rete @gaede