Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refresh cookie token bugs #227

Merged
merged 8 commits into from
Feb 23, 2021

Conversation

mehdithreem
Copy link

There was a bug in which /token/refresh/ did not read and update the refresh token cookie. A small refactoring is also included.

@iMerica
Copy link
Owner

iMerica commented Feb 20, 2021

Thanks for submitting this pull request. I'm setting up Circle CI to build this, but I noticed the test dj_rest_auth.tests.test_api.APIBasicTests.test_custom_token_refresh_view is failing locally. I'm not sure if it's because the assertion is no longer valid or your changes introduced a genuine regression.

Can you have a look? You can run tests locally using tox --parallel (run all tests in all supported Django/Python versions -- in parallel).

@mehdithreem
Copy link
Author

Sure, I will check this.

@mehdithreem
Copy link
Author

@iMerica all tests passed.

@iMerica
Copy link
Owner

iMerica commented Feb 23, 2021

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants