Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring(serializers): move error messages from variables and add translation #318

Closed
wants to merge 1 commit into from

Conversation

MiloLug
Copy link

@MiloLug MiloLug commented Oct 14, 2021

Error messages moved directly to the error instead of the variables.
Invalid value translation added.

@iMerica
Copy link
Owner

iMerica commented Mar 26, 2023

I tried to fix your conflict, but pushing for maintainers is disabled on that git remote.

@iMerica iMerica closed this Mar 26, 2023
@merwok
Copy link

merwok commented Mar 26, 2023

Out of curiosity, why move the error messages from variables?
It’s a style I use often in my own validation code, gives more room to write the message and avoids the delimiters salad of ({...: [_("...")]})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants