Merge pull request Homebrew#8896 from reitermarkus/sorbet-inline

Inline type annotations.
iMichka · Oct 13, 2020 · bf7fe45 · bf7fe45
2 parents 2a9bb36 + 73dc98d
commit bf7fe45
Show file tree

Hide file tree

Showing 894 changed files with 1,689 additions and 1,838 deletions.
diff --git a/.github/workflows/sorbet.yml b/.github/workflows/sorbet.yml
@@ -1,4 +1,4 @@
-name: Update Sorbet-related files
+name: Update Sorbet files
 on:
   push:
     paths:
@@ -39,7 +39,8 @@ jobs:
 
           if brew typecheck --update --fail-if-not-changed; then
             git add "$GITHUB_WORKSPACE/Library/Homebrew/sorbet"
-            git commit -m "sorbet: Update RBI files and prune files.yaml." -m "Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml)."
+            git commit -m "sorbet: Update RBI files." \
+                       -m "Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow."
             echo "::set-output name=committed::true"
             if [ -n "$BRANCH_EXISTS" ]; then
               echo "::set-output name=pull_request::true"

diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml
@@ -12,7 +12,12 @@ AllCops:
   DisplayCopNames: false
   # enable all pending rubocops
   NewCops: enable
+  Include:
+    - '**/*.rbi'
   Exclude:
+    - 'Homebrew/sorbet/rbi/gems/**/*.rbi'
+    - 'Homebrew/sorbet/rbi/hidden-definitions/**/*.rbi'
+    - 'Homebrew/sorbet/rbi/todo.rbi'
     - 'Homebrew/bin/*'
     - 'Homebrew/vendor/**/*'
 
@@ -62,6 +67,10 @@ Naming/HeredocDelimiterNaming:
   ForbiddenDelimiters:
     - END, EOD, EOF
 
+Naming/MethodName:
+  IgnoredPatterns:
+    - '\AHEAD\?\Z'
+
 # Allow dashes in filenames.
 Naming/FileName:
   Regex: !ruby/regexp /^[\w\@\-\+\.]+(\.rb)?$/
@@ -264,9 +273,14 @@ Layout/LineLength:
                     ' "~/Library/Application Support/', '"~/Library/Caches/', '"~/Application Support',
                     ' was verified as official when first introduced to the cask']
 
-# Enable once we are using `sorbet-runtime`.
 Sorbet/FalseSigil:
-  Enabled: false
+  Exclude:
+    - 'Taps/**/*.rb'
+    - 'Homebrew/test/**/Casks/**/*.rb'
+
+Sorbet/StrictSigil:
+  Include:
+    - '**/*.rbi'
 
 # Try getting rid of these.
 Sorbet/ConstantsFromStrings:
@@ -302,6 +316,7 @@ Style/ClassVars:
 Style/Documentation:
   Exclude:
     - 'Taps/**/*'
+    - '**/*.rbi'
 
 Style/DocumentationMethod:
   Include:
@@ -313,6 +328,7 @@ Style/FrozenStringLiteralComment:
   Exclude:
     - 'Taps/*/*/{Formula,Casks,}/*.rb'
     - 'Homebrew/test/**/Casks/**/*.rb'
+    - '**/*.rbi'
 
 # TODO: remove this when possible.
 Style/GlobalVars:

diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml
@@ -45,10 +45,6 @@ Naming/PredicateName:
   # Can't rename these.
   AllowedMethods: is_32_bit?, is_64_bit?
 
-Style/FrozenStringLiteralComment:
-  Exclude:
-    - '**/Casks/**/*.rb'
-
 Style/HashAsLastArrayItem:
   Exclude:
     - 'test/utils/spdx_spec.rb'
diff --git a/Library/Homebrew/PATH.rb b/Library/Homebrew/PATH.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 # Represention of a `*PATH` environment variable.

diff --git a/Library/Homebrew/bintray.rb b/Library/Homebrew/bintray.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "utils/curl"

diff --git a/Library/Homebrew/brew.rb b/Library/Homebrew/brew.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 if ENV["HOMEBREW_STACKPROF"]

diff --git a/Library/Homebrew/build.rb b/Library/Homebrew/build.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 # This script is loaded by formula_installer as a separate instance.

diff --git a/Library/Homebrew/build_environment.rb b/Library/Homebrew/build_environment.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 # Settings for the build environment.

diff --git a/Library/Homebrew/build_options.rb b/Library/Homebrew/build_options.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 # Options for a formula build.

diff --git a/Library/Homebrew/cache_store.rb b/Library/Homebrew/cache_store.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "json"

diff --git a/Library/Homebrew/cask.rb b/Library/Homebrew/cask.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact"

diff --git a/Library/Homebrew/cask/artifact.rb b/Library/Homebrew/cask/artifact.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/app"

diff --git a/Library/Homebrew/cask/artifact/abstract_artifact.rb b/Library/Homebrew/cask/artifact/abstract_artifact.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/artifact/abstract_flight_block.rb b/Library/Homebrew/cask/artifact/abstract_flight_block.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/abstract_artifact"

diff --git a/Library/Homebrew/cask/artifact/abstract_uninstall.rb b/Library/Homebrew/cask/artifact/abstract_uninstall.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "timeout"

diff --git a/Library/Homebrew/cask/artifact/app.rb b/Library/Homebrew/cask/artifact/app.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/artifact.rb b/Library/Homebrew/cask/artifact/artifact.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/audio_unit_plugin.rb b/Library/Homebrew/cask/artifact/audio_unit_plugin.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/binary.rb b/Library/Homebrew/cask/artifact/binary.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/symlinked"

diff --git a/Library/Homebrew/cask/artifact/colorpicker.rb b/Library/Homebrew/cask/artifact/colorpicker.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/dictionary.rb b/Library/Homebrew/cask/artifact/dictionary.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/font.rb b/Library/Homebrew/cask/artifact/font.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/input_method.rb b/Library/Homebrew/cask/artifact/input_method.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/installer.rb b/Library/Homebrew/cask/artifact/installer.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/artifact/abstract_artifact"

diff --git a/Library/Homebrew/cask/artifact/internet_plugin.rb b/Library/Homebrew/cask/artifact/internet_plugin.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/manpage.rb b/Library/Homebrew/cask/artifact/manpage.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/symlinked"

diff --git a/Library/Homebrew/cask/artifact/mdimporter.rb b/Library/Homebrew/cask/artifact/mdimporter.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/moved.rb b/Library/Homebrew/cask/artifact/moved.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/artifact/relocated"

diff --git a/Library/Homebrew/cask/artifact/pkg.rb b/Library/Homebrew/cask/artifact/pkg.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "plist"

diff --git a/Library/Homebrew/cask/artifact/postflight_block.rb b/Library/Homebrew/cask/artifact/postflight_block.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/abstract_flight_block"

diff --git a/Library/Homebrew/cask/artifact/preflight_block.rb b/Library/Homebrew/cask/artifact/preflight_block.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/abstract_flight_block"

diff --git a/Library/Homebrew/cask/artifact/prefpane.rb b/Library/Homebrew/cask/artifact/prefpane.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/qlplugin.rb b/Library/Homebrew/cask/artifact/qlplugin.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/relocated.rb b/Library/Homebrew/cask/artifact/relocated.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/abstract_artifact"

diff --git a/Library/Homebrew/cask/artifact/screen_saver.rb b/Library/Homebrew/cask/artifact/screen_saver.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/service.rb b/Library/Homebrew/cask/artifact/service.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/stage_only.rb b/Library/Homebrew/cask/artifact/stage_only.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/abstract_artifact"

diff --git a/Library/Homebrew/cask/artifact/suite.rb b/Library/Homebrew/cask/artifact/suite.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/symlinked.rb b/Library/Homebrew/cask/artifact/symlinked.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/artifact/relocated"

diff --git a/Library/Homebrew/cask/artifact/uninstall.rb b/Library/Homebrew/cask/artifact/uninstall.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/artifact/abstract_uninstall"

diff --git a/Library/Homebrew/cask/artifact/vst3_plugin.rb b/Library/Homebrew/cask/artifact/vst3_plugin.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/vst_plugin.rb b/Library/Homebrew/cask/artifact/vst_plugin.rb
@@ -1,3 +1,4 @@
+# typed: strict
 # frozen_string_literal: true
 
 require "cask/artifact/moved"

diff --git a/Library/Homebrew/cask/artifact/zap.rb b/Library/Homebrew/cask/artifact/zap.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/artifact/abstract_uninstall"

diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/denylist"

diff --git a/Library/Homebrew/cask/auditor.rb b/Library/Homebrew/cask/auditor.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 require "cask/audit"

diff --git a/Library/Homebrew/cask/cache.rb b/Library/Homebrew/cask/cache.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cask.rb b/Library/Homebrew/cask/cask.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/cask_loader"

diff --git a/Library/Homebrew/cask/cask_loader.rb b/Library/Homebrew/cask/cask_loader.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/cache"

diff --git a/Library/Homebrew/cask/caskroom.rb b/Library/Homebrew/cask/caskroom.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "utils/user"

diff --git a/Library/Homebrew/cask/cmd.rb b/Library/Homebrew/cask/cmd.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "optparse"

diff --git a/Library/Homebrew/cask/cmd/--cache.rb b/Library/Homebrew/cask/cmd/--cache.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/abstract_command.rb b/Library/Homebrew/cask/cmd/abstract_command.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "search"

diff --git a/Library/Homebrew/cask/cmd/abstract_internal_command.rb b/Library/Homebrew/cask/cmd/abstract_internal_command.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/audit.rb b/Library/Homebrew/cask/cmd/audit.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "utils/github/actions"

diff --git a/Library/Homebrew/cask/cmd/cat.rb b/Library/Homebrew/cask/cmd/cat.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/create.rb b/Library/Homebrew/cask/cmd/create.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/doctor.rb b/Library/Homebrew/cask/cmd/doctor.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/edit.rb b/Library/Homebrew/cask/cmd/edit.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/fetch.rb b/Library/Homebrew/cask/cmd/fetch.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/help.rb b/Library/Homebrew/cask/cmd/help.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/home.rb b/Library/Homebrew/cask/cmd/home.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/info.rb b/Library/Homebrew/cask/cmd/info.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "json"

diff --git a/Library/Homebrew/cask/cmd/install.rb b/Library/Homebrew/cask/cmd/install.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/internal_help.rb b/Library/Homebrew/cask/cmd/internal_help.rb
@@ -1,3 +1,4 @@
+# typed: true
 # frozen_string_literal: true
 
 module Cask

diff --git a/Library/Homebrew/cask/cmd/internal_stanza.rb b/Library/Homebrew/cask/cmd/internal_stanza.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/dsl"

diff --git a/Library/Homebrew/cask/cmd/list.rb b/Library/Homebrew/cask/cmd/list.rb
@@ -1,3 +1,4 @@
+# typed: false
 # frozen_string_literal: true
 
 require "cask/artifact/relocated"