Add support for AtlanticHeatRecoveryVentilation

[iMicknl]

Fixes #376

[vlebourl]

is this still needed?

[tillstaff]

I find a typo error in the pyoverkiz library ('O' is missing in VENTILATION) :
SET_VENTILATIN_MODE = "setVentilationMode"
The presets and cooling modes need this command to work properly.

[tillstaff]

ha-tahoma/custom_components/tahoma/climate_devices/atlantic_heat_recovery_ventilation.py

Line 87 in f0aff74

if prog == OverkizCommandParam.PROG:

We have to replace "OverkizCommandParam.PROG" by "OverkizCommandParam.ON" because the value to compare is "on"

[iMicknl]

I find a typo error in the pyoverkiz library ('O' is missing in VENTILATION) :

SET_VENTILATIN_MODE = "setVentilationMode"

The presets and cooling modes need this command to work properly.

Even though we need to fix this typo, this should not matter. The typo is only in our constant, not in the actual exposed value.

[vlebourl]

Even though we need to fix this typo, this should not matter. The typo is only in our constant, not in the actual exposed value.

But wouldn't that make that fail ?

        ventilation_mode = self.executor.select_state(OverkizState.IO_VENTILATION_MODE)

[tillstaff]

But wouldn't that make that fail ?

        ventilation_mode = self.executor.select_state(OverkizState.IO_VENTILATION_MODE)

Not this one, but the following command fail for sure :

        await self.executor.async_execute_command(
            OverkizCommand.SET_VENTILATION_MODE, ventilation_mode
        )

By the way, even with the correct command, there is an error from Cozytouch.

[tillstaff]

Hi @iMicknl,
Could you fix the typo error and update with the last commits from master build instead?

[tillstaff]

By the way, even with the correct command, there is an error from Cozytouch.

I think this error is linked to the following logs :

Logger: custom_components.tahoma
Source: helpers/update_coordinator.py:219
Integration: Overkiz (by Somfy) - Custom component
First occurred: March 16, 2022, 3:43:59 PM (14 occurrences)
Last logged: March 16, 2022, 4:49:39 PM

Error fetching device events data: Too many requests, try again later.

Logger: custom_components.tahoma.climate_devices.atlantic_electrical_heater_with_adjustable_temperature_setpoint
Source: custom_components/tahoma/climate_devices/atlantic_electrical_heater_with_adjustable_temperature_setpoint.py:158
Integration: Overkiz (by Somfy) - Custom component
First occurred: March 16, 2022, 3:43:59 PM (56 occurrences)
Last logged: March 16, 2022, 4:49:39 PM

Unable to update from sensor: could not convert string to float: 'unavailable'

The problem is that the "refresh" commands takes a lot of time to execute and it seems the cozytouch API refuse other requests during the execution.
Is it possible to add some delay to wait the end of the execution of "refresh" commands?

[iMicknl]

@tillstaff this one is very hard for me to debug without actual access. Is this PR currently working or still broken?

I am looking if this one can be migrated to core as well.

[tillstaff]

@tillstaff this one is very hard for me to debug without actual access. Is this PR currently working or still broken?

I am looking if this one can be migrated to core as well.

@iMicknl this PR is working, all the commands are working with the corrections in the last comments.

One of the log error can be solve with this change :
if state is None or state.state == STATE_UNAVAILABLE:
instead of if state is None or state.state == STATE_UNKNOWN:

For the other error log, I don't know how we can avoid the "too many request error".

[iMicknl]

Did you test the latest version? if state is None or state.state == STATE_UNAVAILABLE: this is not used anymore?

I just applied your suggestions. Could you check if everything works now? Does the too many request error happen a lot, or only during testing (when you reboot a lot) and maybe even have 2 installations running at the same time?

[tillstaff]

Thanks for the commits, I will test this new build.

The correction if state is None or state.state == STATE_UNAVAILABLE: has to be applied in another climate device, click the following link : if state is None or state.state == STATE_UNKNOWN:
I don't know if it replaces STATE_UNKNOWN or if we have to add it after.

The log error "too many request" appears each time I change the preset or the fan-mode.
Adding some delay with time.sleep(3) helps a lot, but I don't know if it's a good solution.

[iMicknl]

The correction if state is None or state.state == STATE_UNAVAILABLE: has to be applied in another climate device, click the following link : if state is None or state.state == STATE_UNKNOWN:
I don't know if it replaces STATE_UNKNOWN or if we have to add it after.

We moved away from this part of the code, thus when we add it to core, this will be fixed as well.

The log error "too many request" appears each time I change the preset or the fan-mode.
Adding some delay with time.sleep(3) helps a lot, but I don't know if it's a good solution.

I will have a look, in the end we should group these commands in a single call.. Are the refresh calls needed?

[tillstaff]

The log error "too many request" appears each time I change the preset or the fan-mode.
Adding some delay with time.sleep(3) helps a lot, but I don't know if it's a good solution.

I will have a look, in the end we should group these commands in a single call.. Are the refresh calls needed?

Yes, there are needed. I made some tests without them and the states of the VMC were totally wrong after that.

I made some new traces with the cozytouch app and I confirm that the two first commands (setVentilationMode and setVentilationConfigurationMode) are send in a single call and the two refresh commands are send later in a single call (1.5 seconds after the end of execution of the first commands).

9:12:18.700 (end at 9:12:19.372) : INFO (MainThread) [custom_components.tahoma] HistoryExecution(id='ebb1490a-d9b6-8679-6435-065e846e8db3', event_time=1648926738700, owner=GACOMA_Production_24148, source='mobile:mobile', end_time=1648926739372, effective_start_time=1648926738700, duration=672, label='Android 3.1.0#310 Set device mode : PROG', type='Immediate execution - MANUAL_CONTROL', state=<ExecutionState.COMPLETED: 'COMPLETED'>, failure_type='NO_FAILURE', commands=[HistoryExecutionCommand(device_url=io://****-****-6923/15021786#1, command='setVentilationMode', rank=0, dynamic=False, state=<ExecutionState.COMPLETED: 'COMPLETED'>, failure_type='NO_FAILURE', parameters=[{'test': 'off', 'end_of_line_test': 'off', 'leap_year': 'off', 'prog': 'on', 'month': 4, 'day_night': 'night', 'cooling': 'off', 'day': 2}]), HistoryExecutionCommand(device_url=io://****-****-6923/15021786#1, command='setVentilationConfigurationMode', rank=1, dynamic=False, state=<ExecutionState.COMPLETED: 'COMPLETED'>, failure_type='NO_FAILURE', parameters=['standard'])], execution_type=<ExecutionType.IMMEDIATE_EXECUTION: 'Immediate execution'>, execution_sub_type=<ExecutionSubType.MANUAL_CONTROL: 'MANUAL_CONTROL'>)

9:12:20.696 (end at 9:12:21.878) : INFO (MainThread) [custom_components.tahoma] HistoryExecution(id='ebb150d7-d9b6-8679-6435-065e5d6e26c1', event_time=1648926740696, owner=GACOMA_Production_24148, source='mobile:mobile', end_time=1648926741878, effective_start_time=1648926740697, duration=1181, label='Android 3.1.0#310 null', type='Immediate execution - MANUAL_CONTROL', state=<ExecutionState.COMPLETED: 'COMPLETED'>, failure_type='NO_FAILURE', commands=[HistoryExecutionCommand(device_url=io://****-****-6923/15021786#1, command='refreshVentilationState', rank=0, dynamic=False, state=<ExecutionState.COMPLETED: 'COMPLETED'>, failure_type='NO_FAILURE', parameters=[]), HistoryExecutionCommand(device_url=io://****-****-6923/15021786#1, command='refreshVentilationConfigurationMode', rank=1, dynamic=False, state=<ExecutionState.COMPLETED: 'COMPLETED'>, failure_type='NO_FAILURE', parameters=[])], execution_type=<ExecutionType.IMMEDIATE_EXECUTION: 'Immediate execution'>, execution_sub_type=<ExecutionSubType.MANUAL_CONTROL: 'MANUAL_CONTROL'>)

Can we build the same commands requests?

[tillstaff]

Hello @iMicknl and @tetienne,
Is it possible to add this PR to the master branch?
Some commands are not working well and need a way to send two commands in one request, but all is ok for the other commands.

[iMicknl]

@tetienne if you can approve, I will merge. Perhaps we can bring this one to core a well?

[tetienne]

We can use a dict here no?

[iMicknl]

I will have a look, thanks!

[iMicknl]

@tetienne you mean a dict for ventilation_configuration? Since we need to check from two values. (prog and ventilation_configuration).

[tetienne]

We can use ClimateEntityFeatures here

[iMicknl]

I will do that for core, but otherwise I need to bump the custom component version etc. :D

[tetienne]

OK to be merged.