Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyoverkiz to 1.3.14 #799

Merged

Conversation

vlebourl
Copy link
Collaborator

@vlebourl vlebourl commented Apr 8, 2022

Requirements between custom and core component regarding pyoverkiz need to be kept in sync otherwise error such as the following can happen:

Logger: homeassistant.config_entries
Source: config_entries.py:745
First occurred: 09:18:08 (2 occurrences)
Last logged: 09:18:11

Error occurred loading configuration flow for integration overkiz: cannot import name 'TooManyAttemptsBannedException' from 'pyoverkiz.exceptions' (/usr/local/lib/python3.9/site-packages/pyoverkiz/exceptions.py)

fixes the following error when using custom component caused by core overkiz requiring 1.3.14.
```py
Logger: homeassistant.config_entries
Source: config_entries.py:745
First occurred: 09:18:08 (2 occurrences)
Last logged: 09:18:11

Error occurred loading configuration flow for integration overkiz: cannot import name 'TooManyAttemptsBannedException' from 'pyoverkiz.exceptions' (/usr/local/lib/python3.9/site-packages/pyoverkiz/exceptions.py)
```
@github-actions github-actions bot added the bug Something isn't working label Apr 8, 2022
Copy link
Collaborator

@tetienne tetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rephrase the PR title before merging.

@vlebourl
Copy link
Collaborator Author

vlebourl commented Apr 8, 2022

how would you rename ? simply bump pyoverkiz ?

@vlebourl vlebourl changed the title Fix/cannot import name too many attempts banned exception Bump pyoverkiz to 1.3.14 Apr 10, 2022
@vlebourl vlebourl merged commit c1bf9e3 into master Apr 10, 2022
@vlebourl vlebourl deleted the fix/cannot-import-name-TooManyAttemptsBannedException branch April 10, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants