-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip None value, fixes retrieval of diagnostics #1157
Conversation
…tant/core#111818 * pyoverkiz/obfuscate.py:
Would it be possible to add your setup.json to the repo as well and add this to our test suite? Regarding the linting issue, fine by me to disable this rule via a comment in your code. |
* pyoverkiz/obfuscate.py:
Ok, disabled the rule, added my json to the fixtures/setup directory, is that the correct place? |
Apparently we don't have a test yet for the obfuscate feature; but good to add your fixture nevertheless. |
For the obfuscate feature, the problem is I think this list in the raw data |
* tests/test_obfuscate.py:
And added a test case for this, without my patch the test fails with
|
Fixes diagnostics retrieval issue as part of home-assistant/core#111818