Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overkiz State, Command, CommandParameter enums #228

Merged
merged 13 commits into from
Nov 15, 2021
Merged

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Nov 1, 2021

No description provided.

Copy link
Collaborator

@tetienne tetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file starts to be too big. Can you add this in another module?

@iMicknl
Copy link
Owner Author

iMicknl commented Nov 1, 2021

This file starts to be too big. Can you add this in another module?

I was looking into that indeed, how to more easily split this in multiple files. I would like to keep the import simple, instead of having to import from a specific file.

@iMicknl
Copy link
Owner Author

iMicknl commented Nov 1, 2021

@tetienne would you know if we can easily change the import to have it from .enum instead of .enum.command? Or should we just settle for new paths.

@tetienne
Copy link
Collaborator

tetienne commented Nov 1, 2021

@tetienne would you know if we can easily change the import to have it from .enum instead of .enum.command? Or should we just settle for new paths.

Perhaps adding the import within the __init__.py file. But, like this it does not hurt me.

from .gateway import *
from .general import *
from .state import *
from .ui import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was useful finally?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason why I did this is to have everything as an import from enums (which is also non breaking :D).

ZWAVE_SEDEVICE_CONFIGURATION = "ZWaveSEDeviceConfiguration"
ZWAVE_TRANSCEIVER = "ZWaveTransceiver"
ZIGBEE_NETWORK = "ZigbeeNetwork"
ZIGBEE_STACK = "ZigbeeStack"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s insane. How can they maintain all these widgets?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know haha, but they were already added to the enums. Didn't see that before :o.

@iMicknl iMicknl merged commit fa737ff into master Nov 15, 2021
@iMicknl iMicknl deleted the feature/add_enum branch November 15, 2021 10:50
tetienne pushed a commit that referenced this pull request Feb 14, 2023
* Add enums

* Extend enum

* Split enums over files

* Fix tests

* Fix tests (2)

* Style fix

* Move import to .enums

* Fix tests

* Fix typo

* Fix typo

* Fix typo

* Fix widget style

* Fix names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants