-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Overkiz State, Command, CommandParameter enums #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file starts to be too big. Can you add this in another module?
I was looking into that indeed, how to more easily split this in multiple files. I would like to keep the import simple, instead of having to import from a specific file. |
@tetienne would you know if we can easily change the import to have it from |
Perhaps adding the import within the |
3905175
to
1d99f5a
Compare
from .gateway import * | ||
from .general import * | ||
from .state import * | ||
from .ui import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it was useful finally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason why I did this is to have everything as an import from enums
(which is also non breaking :D).
ZWAVE_SEDEVICE_CONFIGURATION = "ZWaveSEDeviceConfiguration" | ||
ZWAVE_TRANSCEIVER = "ZWaveTransceiver" | ||
ZIGBEE_NETWORK = "ZigbeeNetwork" | ||
ZIGBEE_STACK = "ZigbeeStack" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s insane. How can they maintain all these widgets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know haha, but they were already added to the enums. Didn't see that before :o.
* Add enums * Extend enum * Split enums over files * Fix tests * Fix tests (2) * Style fix * Move import to .enums * Fix tests * Fix typo * Fix typo * Fix typo * Fix widget style * Fix names
No description provided.