Fix local error messages

[iMicknl]

Follow up on #843 (comment).

@shypike can you verify if this is the right fix?

[shypike]

It should be OK, but I'll add it to my own installation. And I will try to catch the error condition.
I can give you feedback tomorrow.

[iMicknl]

It should be OK, but I'll add it to my own installation. And I will try to catch the error condition. I can give you feedback tomorrow.

Thanks! Let me know :) would be good to catch some JSON files so we can eventually add tests.

[tetienne]

If we don’t add any test, it would be nice to add as comment an example of why we trip the ".

[iMicknl]

Agree! Preferably both 😄.

[shypike]

It looks like this one is the only deviation:

{"error":"\"No registered event listener.\"","errorCode":"UNSPECIFIED_ERROR"}

[shypike]

I've tested some issues with both Cloud and Local (I cannot reproduce them all).
Cloud says:

{"errorCode":"UNSPECIFIED_ERROR","error":"No registered event listener"}
{"errorCode":"RESOURCE_ACCESS_DENIED","error":"Not authenticated"}

Local says:

400: {"error":"\"No registered event listener.\"","errorCode":"UNSPECIFIED_ERROR"}
401: {"error":"Not authenticated.","errorCode":"RESOURCE_ACCESS_DENIED"}
400: {"error":"Unknown object.","errorCode":"UNSPECIFIED_ERROR"}
401: {"error":"Missing authorization token.","errorCode":"RESOURCE_ACCESS_DENIED"}

Note also that Local ends some messages with a full-stop "." and Cloud does not.
It's these nasty little differences that make me prefer in instead of ==.
Or at least use this:

message = result.get("error").strip("\"'.")

[iMicknl]

Thanks @shypike. Do you know which HTTP code these requests have?

[shypike]

I've added the error codes to the original message,
Of course the required change is not just stripping with .strip(""'.") but also removing the trailing "." from the string comparisons.

[iMicknl]

Thanks! @shypike, I implemented it in #870.