Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue: #20 #22

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix for issue: #20 #22

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58dbcf2
Fix for #17: https://github.com/iMicknl/python-postnl-api/issues/17
0x00-0xFF Dec 5, 2019
90cabd4
Sync with upstream
0x00-0xFF Dec 13, 2019
4f9fb20
Fix to Unauthorized exception (again...)
0x00-0xFF Dec 13, 2019
3aa1f13
Merge branch 'master' into master
0x00-0xFF Dec 13, 2019
c53cb54
Use of variable AUTHENTICATE_URL
0x00-0xFF Dec 13, 2019
c73a4b1
Merge branch 'master' of https://github.com/0x00-0xFF/python-postnl-api
0x00-0xFF Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 11 additions & 13 deletions postnl_api/postnl_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,22 +160,20 @@ def _request_update(self, url, count=0, max=3):
return response.json()

def _request_login(self):
headers = {"Content-Type": "application/x-www-form-urlencoded"}

payload = {
"grant_type": "password",
"client_id": "pwAndroidApp",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would changing pwAndroidApp to pwWebApp not be enough? I am not sure why the whole call should be changed.

However if this fixes the problem, I am happy to merge and publish.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes the autorisation issues in Home Assistant

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to release this fix?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scornelissen85 sure! But to be honest I am not sure if this will fix it.

I did plan to do a full rewrite of the integration, however I have been more busy than expected lately, thus this will take a few weeks.

Were you able to confirm that this change still works?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried the fix, it will not work anymore.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iMicknl what are your thoughts?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peternijssen the approach mentioned above feels a bit hacky, but looks doable.

I just bought a house and I am in the planning and hopefully soon moving process, thus a bit more busy lately. However, this is certainly something I want for my new house ;-).

Copy link

@1ntroduc3 1ntroduc3 Jul 19, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoGoGadget 💯 let's hope this can be implemented and can result again in a working PostNL function at home assistant 🤓
Good luck moving @iMicknl

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried the fix menionted, but that still does not work for me.
Also, the procedure is very different, it uses a shell script which places a cookie and scraped the html pages into tmp files.
The login procdure constist of a number of steps, with some generated tokens/codes/challenges and such.

A python script must probably do the same, which might be a challenge.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peternijssen did you get a reply back from PostNL? I had a look at the shell file and it doesn't work for me, and indeed as @Romkabouter mentions; they use scraping which I would like to avoid..

"username": self._user,
"password": self._password,
headers = {
'$Accept': '*/*',
'$Accept-Encoding': 'gzip, deflate',
'$Content-Type': 'application/x-www-form-urlencoded',
}

payload = "client_id=pwWebApp&grant_type=password&password={}&username={}".format(self._password,
self._user)

try:
response = requests.request(
"POST",
AUTHENTICATE_URL,
data=payload,
headers={**headers, **DEFAULT_HEADER},
)
response = requests.post(AUTHENTICATE_URL,
headers=headers,
data=payload,
verify=True)
data = response.json()

except Exception:
Expand Down