Add logout API method #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMicknl
reviewed
Dec 2, 2021
|
Thanks @rhpijnacker! Do you use this with Home Assistant as well, or just in a seperate Python script? |
|
@iMicknl, I am testing this using the example script on the GitHub page. The ultimate goal would be to use this in Home Assistant. |
|
Oops, I missed that you replied here; iMicknl/ha-sagemcom-fast#19 (comment). Happy to merge it in and bring it to HA. |
rhpijnacker
commented
Dec 2, 2021
sagemcom_api/client.py
Outdated
| } | ||
|
|
||
| response = await self.__api_request_async([actions], True) | ||
| data = self.__get_response(response) |
There was a problem hiding this comment.
I guess this __get_response is not actually necessary?
There was a problem hiding this comment.
You can remove it indeed, since we don't do anything with the response. What is the response?
Not sure if we want to throw a bool (True/False depending on the logout result).
iMicknl
reviewed
Dec 2, 2021
iMicknl
reviewed
Dec 5, 2021
| @@ -172,10 +172,6 @@ def __get_response_value(self, response, index=0): | |||
|
|
|||
| async def __api_request_async(self, actions, priority=False): | |||
| """Build request to the internal JSON-req API.""" | |||
| # Auto login | |||
| if self._server_nonce == "" and actions[0]["method"] != "logIn": | |||
|
This was already part of the other PR I assume :-). Otherwise we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the Getting Started example, the KPN Box 12 keeps returning XMO_MAX_SESSION_COUNT_ERR errors.
This is simply fixed by adding a logout API method and calling this in a try / finally block.