F*ck those warnings!

iNKORE-NET · May 1, 2024 · 4f29905 · 4f29905
1 parent 128e802
commit 4f29905
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/source/iNKORE.UI.WPF.Modern.Controls/Controls/MessageBox/MessageBox.Helper.cs b/source/iNKORE.UI.WPF.Modern.Controls/Controls/MessageBox/MessageBox.Helper.cs
@@ -232,7 +232,7 @@ public partial class MessageBox
         /// <param name="defaultResult">A <see cref="MessageBoxResult"/> value that specifies the default result of the message box.</param>
         /// <returns>A <see cref="MessageBoxResult"/> value that specifies which message box button is clicked by the user.</returns>
         /// <remarks>By default, the message box appears in front of the window that is currently active.</remarks>
-        public static MessageBoxResult Show(Window owner, string messageBoxText, string caption, MessageBoxButton button, IconSource icon, MessageBoxResult? defaultResult, SystemSound? sound = null)
+        public static MessageBoxResult Show(Window owner, string messageBoxText, string caption, MessageBoxButton button, IconSource icon, MessageBoxResult? defaultResult, SystemSound sound = null)
         {
             if (owner is null)
             {

diff --git a/source/iNKORE.UI.WPF.Modern.Controls/Controls/NavigationView/NavigationView.cs b/source/iNKORE.UI.WPF.Modern.Controls/Controls/NavigationView/NavigationView.cs
@@ -1888,17 +1888,17 @@ void UpdateIsClosedCompact()
                     m_initialListSizeStateSet = true;
                     VisualStateManager.GoToState(this, m_isClosedCompact ? "ListSizeCompact" : "ListSizeFull", true /*useTransitions*/);
                 }
-                else if (false /*!SharedHelpers.IsRS3OrHigher()*/) // Do any changes that would otherwise happen on opening/closing for RS2 and earlier:
-                {
-                    // RS3+ animation timing enhancement:
-                    // Pre-RS3, we didn't have the full suite of Closed, Closing, Opened,
-                    // Opening events on SplitView. So when doing open/closed operations,
-                    // we have to do them immediately. Just one example: on RS2 when you
-                    // close the pane, the PaneTitle will disappear *immediately* which
-                    // looks janky. But on RS4, it'll have its visibility set after the
-                    // closed event fires.
-                    VisualStateManager.GoToState(this, m_isClosedCompact ? "ListSizeCompact" : "ListSizeFull", true /*useTransitions*/);
-                }
+                //else if (!SharedHelpers.IsRS3OrHigher()) // Do any changes that would otherwise happen on opening/closing for RS2 and earlier:
+                //{
+                //    // RS3+ animation timing enhancement:
+                //    // Pre-RS3, we didn't have the full suite of Closed, Closing, Opened,
+                //    // Opening events on SplitView. So when doing open/closed operations,
+                //    // we have to do them immediately. Just one example: on RS2 when you
+                //    // close the pane, the PaneTitle will disappear *immediately* which
+                //    // looks janky. But on RS4, it'll have its visibility set after the
+                //    // closed event fires.
+                //    VisualStateManager.GoToState(this, m_isClosedCompact ? "ListSizeCompact" : "ListSizeFull", true /*useTransitions*/);
+                //}
 
                 UpdateTitleBarPadding();
                 UpdateBackAndCloseButtonsVisibility();

diff --git a/source/iNKORE.UI.WPF.Modern.Controls/Controls/RatingControl/RatingControlAutomationPeer.cs b/source/iNKORE.UI.WPF.Modern.Controls/Controls/RatingControl/RatingControlAutomationPeer.cs
@@ -38,7 +38,7 @@ string IValueProvider.Value
                 double ratingValue = GetRatingControl().Value;
                 string valueString;
 
-                string ratingString;
+                // string ratingString;
 
                 if (ratingValue == -1)
                 {