Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Output Mapping #1821

Closed
shota3527 opened this issue Sep 10, 2023 · 6 comments
Closed

Incorrect Output Mapping #1821

shota3527 opened this issue Sep 10, 2023 · 6 comments

Comments

@shota3527
Copy link
Contributor

shota3527 commented Sep 10, 2023

@mmosca
Thanks for the efforts on smarter pwm mapping. But on the latest master of firmware and configurator.

  1. Servo is not displayed if platform type is multi-rotor/tri copter
    image

  2. Incorrect output mapping if servo index jumped. In actual mapping, servo index 2,3 is mapped to S2,S3. servo3 should be on S3 in the GUI.
    image

# resource
IO:
----------------------
...omitted
C06: SERVO1 OUT
C07: SERVO2 OUT
C08: SERVO3 OUT
...omitted
# smix
smix 0 1 2 100 0 -1
smix 1 3 0 100 0 -1

# mmix

How about using getMotorCount() and getServoCount() in the firmware to get the correct count as a solution?

@mmosca
Copy link
Collaborator

mmosca commented Sep 10, 2023

was this after save and reboot?

@mmosca
Copy link
Collaborator

mmosca commented Sep 10, 2023

And what target was it?

Was it on master?
I certainly have seen that bug in development, but though it was fixed.

@stronnag
Copy link
Collaborator

stronnag commented Sep 10, 2023

Similar UI artefact (master of F/w and configurator). Set in the CLI. MATEKF405.
image

@shota3527
Copy link
Contributor Author

And what target was it?

Was it on master? I certainly have seen that bug in development, but though it was fixed.

It is matekf405, but I have seen something similar on matekf405wte.
The reboot has no effect.

For Incorrect output mapping if servo index jumped, I think it existed a long time ago

@mmosca
Copy link
Collaborator

mmosca commented Sep 10, 2023

let me try to reproduce it here

@mmosca
Copy link
Collaborator

mmosca commented Sep 10, 2023

#1822 should fix this.

@mmosca mmosca closed this as completed in ac1cc38 Sep 10, 2023
mmosca added a commit that referenced this issue Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants