Removed multiple units in the Advanced Tuning tab #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it look cleaner and doesnt have duplicate
|
The ID’s shouldn’t be changed. They are based on the OSD IDs in the firmware. |
MrD-RC
requested changes
Dec 23, 2021
|
Should be fixed now |
It still looks incorrect in the source code. |
|
swapped them around |
MrD-RC
approved these changes
Dec 30, 2021
|
The getUnitDisplayTypeValue const is all good now. |
|
Approval from Pawel, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be multiple units in the Advanced Tuning tab, firstly the units at the end of the description next to the input, and the units which appear when you change the units for the configurator. This can be confusing for people.
I have removed the units from the descriptions. Added tags to the inputs denoting the unit type. Changed some code in the settings file which goes through all the inputs and shows the appropriate unit. Converting between units still works.
This is my first contribution to this/any public project, Thanks.