Magnetometer tab alignment tool #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model_replaced Improvments for mag helper without iframe
…ment Slider added, improved UI
…b_improvments # Conflicts: # _locales/en/messages.json
This was referenced Apr 4, 2022
|
awesome! merging! |
|
Thanks for taking over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry to open another PR for this feature, but in the original PR #1449 i must wait a lot of time until @ThisIsJustARandomGuy merges my changes, last time he took more than one month, so the development time was very slow.
I can understand also my multiple PR on @ThisIsJustARandomGuy branch, instead to do only one PR.
This PR contains the initial work done by @ThisIsJustARandomGuy plus my additions.
Few notes about the works done in this PR:
We have the alignment tool inside INAV Configurator
I've updated the TREEJS version from 0.72(that we use from cleanflight) to the latest, so the old JSON 3d models were not more supported, so i converted them to .glTF files (a more compatible format supported by a lot of 3d software).
We have also a new fallback model! (the cube shown when the UAV has not a 3d model)
Some users like @rts18 tells me the importance to have also an FC alignment tool built-in. I've tested the tool with different FC orientation, and seems that the magnetometer align must be done referring to the flight controller and not the the UAV orientation.
If for example you have changed your flight controller alignment, make your adjustment relative to the arrow on the FC and not to the UAV orientation.
I've added a message that explain this.