Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Craft name enhancments #1506

Merged
merged 1 commit into from Apr 20, 2022
Merged

Craft name enhancments #1506

merged 1 commit into from Apr 20, 2022

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Apr 20, 2022 •
edited

  • Moved craft name to OSD page
  • OSD preview matches actual craft name
  • Only accept usable characters and symbols
  • No firmware changes needed with current master

Demo video

If folks still want the craft name on the Configuration page. I can put that back. But, I didn't really see the point of the replication.

Release Note

  • The Craft Name field has been moved from the Configuration tab to the OSD tab

@MrD-RC
Craft name enhancments
ab9e3cc 
- Moved craft name to OSD page
- OSD preview matches actual craft name
- Only accept usable characters and symbols
@MrD-RC MrD-RC added this to the 5.0 milestone Apr 20, 2022
@MrD-RC MrD-RC merged commit aa21987 into master Apr 20, 2022
@MrD-RC MrD-RC deleted the MrD_Variable-length-craft-name branch April 20, 2022 12:22
@MrD-RC MrD-RC added the Release Notes Add this when a PR needs to be mentioned in the release notes label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DzikuVx DzikuVx DzikuVx approved these changes

Assignees
No one assigned
Labels
Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MrD-RC @DzikuVx