Mission Control: Bug fixes related to P3 field #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added const to make bitfield stuff more readable - changed `checkAltElevationSanity()` as it was treating P3 as a Boolean. Some times this function was called with explicitly not using absolute altitude. This is still possible. The function can accept a Boolean _or_ the P3 bitfield. - Fixed issue where alt and user action checkboxes could not be unset. - Added **.mission** filter to the load mission from file dialog box.
One other change to stop using P3 as a Boolean.
breadoven
reviewed
Feb 14, 2023
Fixed the cat's contribution.
breadoven
reviewed
Feb 14, 2023
breadoven
reviewed
Feb 14, 2023
breadoven
reviewed
Feb 14, 2023
…com/iNavFlight/inav-configurator into MrD_Fix-alt-type-in-mission-planner
Move storage of P£ til after the check
|
This seems to be correct now, after moving the storing of P3 around line 2125. Changing the toggle now changes the alt in the Alt (cm) box above.
|
breadoven
approved these changes
Feb 15, 2023
Revise setBit function
I tried your function and it worked fine. So I swapped it in as it it neater too. I'm still fairly new to all the bitwise stuff. Also, I remembered I found a bug in it which I fixed. That could have also been causing the unwanted behaviour. Either way. This is all working nicely now, so I'll get it merged, ready for RC3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1721
checkAltElevationSanity()as it was treating P3 as a Boolean. Some times this function was called with explicitly not using absolute altitude. This is still possible. The function can accept a Boolean or the P3 bitfield.