Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nativejs/game app v2.0: reD #16

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Nativejs/game app v2.0: reD #16

merged 6 commits into from
Jan 23, 2024

Conversation

iPoetDev
Copy link
Owner

  • Patch: Reorganisation of Repository and folders
  • Docs: Edited Readme
  • fix/Linted: Javascript Files with JSHint
  • Assets: Added Reference web safe fonts locally, not using atm
  • Docs: Updated README (DoD List: Todo and Done) + Projects.md

Intent: Align repository with files
Issue:
Fixed:
    -
Files:
    - add src/* to cleaned repositories
ToDo:
Done:
Tag: #GameLogic(), #NativeJS
Sprint:    05: Ends 23-01-22
Deadline:  Submit: Saturday 23 January 2024
Bump: 02.01.000 due to breaking change and switch to Native JS.
Previous:  23-01-22 v02.02.01.03
Changelog: 23-01-22 v02.02.01.04
Branch: nativejs/game-app-v2.0
- bug:
- added
  - src/* in lieu of docs/*
- modified:
- documented:
- refactor:
- rename:
- removed:
    - app.js/game.js from src/assets/js
- fixed:
- logging:
- chore/config
- linted:
  - WebStorm inspections
    - All Clear. 23-01-?? v02.01.00.01
    - Spell checked 23-01-?? v02.01.00.01
  - SonarLint
  - JSHint
  - W3C Style
  - W3C HTML
- edits:
- deploy:
Refs:
-
Intent: Align repository with files
Issue:
Fixed:
    -
Files:
    - add src/* to cleaned repositories
ToDo:
Done:
Tag: #GameLogic(), #NativeJS
Sprint:    05: Ends 23-01-22
Deadline:  Submit: Saturday 23 January 2024
Bump: 02.01.000 due to breaking change and switch to Native JS.
Previous:  23-01-22 v02.02.01.03
Changelog: 23-01-22 v02.02.01.04
Branch: nativejs/game-app-v2.0
- bug:
- added
  - src/* in lieu of docs/*
- modified:
- documented:
- refactor:
- rename:
- removed:
    - app.js/game.js from src/assets/js
- fixed:
- logging:
- chore/config
- linted:
  - WebStorm inspections
    - All Clear. 23-01-?? v02.01.00.01
    - Spell checked 23-01-?? v02.01.00.01
  - SonarLint
  - JSHint
  - W3C Style
  - W3C HTML
- edits:
- deploy:
Refs:
-
Intent: Remove AlpineJS and gramar check
Issue:
Fixed:
    -
Files: In Focus
  -  ✅ README.md
  - Screenshots for README.md
ToDo:
    - Deploy to GitHub.io Pages
    - Clean up logic.js code and unused design/statements
    - Check the draw state: all turns no winners -> UI message
    - check the invalid state/move and update the UI
Done:
Tag: #GameLogic(), #NativeJS, #README
Sprint:    05: Ends 23-01-22
Deadline:  Submit: Saturday 23 January 2024
Bump: 02.01.000 due to breaking change and switch to Native JS.
Previous:  23-01-22 v02.01.00.05
Changelog: 23-01-22 v02.02.01.06
Branch: nativejs/game-app-v2.0
- bug:
    - Clean up broken the tokens being played/switched
    - draw state
    - invalid/bad move
    - one click beyond win state: reference error
- added
- modified:
- documented:
  - Update READ for Native JS and adjusted latest changes
  - Outline breaking change/change of direction
  - Added screenshots and uploaded these
  - Adjusted grammar and spelling
- refactor:
- rename:
- removed:
- fixed:
- logging:
- linted:
  - WebStorm inspections
    - All Clear. 23-01-?? v02.01.00.01
    - Spell checked 23-01-?? v02.01.00.01
  - SonarLint
  - JSHint
  - W3C Style: 24/01/22 @16:01
    - 60 errors, 23 warning from Tailwind
  - W3C HTML 24/01/22 @16:01
    - 1 info, fixed
    - 5 warnings, ignored, as concern on mime types in browsers
- edits:
- deploy:
Refs:
-
Intent: JSHint & JB Inspections Pragmas
    - Adding ignores as known hotspots and fixing issues
Issue:
    - 🐞 Check the draw state: all turns no winners -> UI message
    - See #15
    - 🐞 check the invalid state/move and update the UI
    - See TBC
    - 🐞 one click beyond win state: reference error
Fixed:
    -
Files: In Focus
  -  src/assest/js/*
ToDo:
Done:
    - ✅  Deploy to GitHub.io Pages
    - ✅ Clean up logic.js code and unused design/statements
Tag: #GameLogic(), #NativeJS, #README
Sprint:    05: Ends 23-01-22
Deadline:  Submit: Saturday 23 January 2024
Bump: 02.01.000 due to breaking change and switch to Native JS.
Previous:  23-01-22 v02.01.00.06
Changelog: 23-01-22 v02.02.01.07
Branch: nativejs/game-app-v2.0
- bug:
    - draw state
    - invalid/bad move
    - one click beyond win state: reference error
- added
- modified:
- documented:
- refactor:
- rename:
- removed:
- fixed:
- logging:
- linted: ✅ Completed 2024/01/22
  - WebStorm inspections
    - All Clear. 23-01-?? v02.01.00.01
    - Spell checked 23-01-?? v02.01.00.01
  - SonarLint
  - JSHint  (see section 6.3.2 JS Linting  of README)
    - logging.js
    - logic.js
    - watch.js
    - ui1.js
    - oninitload.js
  - W3C Style: 24/01/22 @16:01
    - 60 errors, 23 warning from Tailwind
  - W3C HTML 24/01/22 @16:01
    - 1 info, fixed
    - 5 warnings, ignored, as concern on mime types in browsers
- edits:
- deploy:
Refs:
-
Intent: Upload of web safe fonts
Issue:
    - 🐞 Check the draw state: all turns no winners -> UI message
    - See #15
    - 🐞 check the invalid state/move and update the UI
    - See TBC
    - 🐞 one click beyond win state: reference error
Fixed:
    -
Files: In Focus
  - src/assets/fonts/*/web/* web safe
ToDo:
Done:
Tag: #GameLogic(), #NativeJS, #README
Sprint:    05: Ends 23-01-23
Deadline:  Submit: Saturday 23 January 2024
Bump: 02.01.000 due to breaking change and switch to Native JS.
Previous:  23-01-23 v02.01.00.08
Changelog: 23-01-23 v02.02.01.09
Branch: nativejs/game-app-v2.0
- bug:
    - draw state
    - invalid/bad move
    - one click beyond win state: reference error
- added
 - web safe fonts for reference and future use.
- modified:
- documented:
- refactor:
- rename:
- removed:
- fixed:
- logging:
- linted: ✅ Completed 2024/01/22
  - W3C Style: 24/01/22 @16:01
    - 60 errors, 23 warning from Tailwind
  - W3C HTML 24/01/22 @16:01
    - 1 info, fixed
    - 5 warnings, ignored, as concern on mime types in browsers
- edits:
- deploy:
Refs:
-
Intent: UPDATE OF README: Todo and Done
Issue:
    - 🐞 Check the draw state: all turns no winners -> UI message
    - See #15
    - 🐞 check the invalid state/move and update the UI
    - See TBC
    - 🐞 one click beyond win state: reference error
Fixed:
    -
Files: In Focus
  - src/assets/fonts/*/web/* web safe
ToDo:
Done:
Tag: #GameLogic(), #NativeJS, #README
Sprint:    05: Ends 23-01-23
Deadline:  Submit: Saturday 23 January 2024
Bump: 02.01.000 due to breaking change and switch to Native JS.
Previous:  23-01-23 v02.01.00.09
Changelog: 23-01-23 v02.02.01.10
Branch: nativejs/game-app-v2.0
- bug:
    - draw state
    - invalid/bad move
    - one click beyond win state: reference error
- added
 - web safe fonts for reference and future use.
- modified:
- documented:
      - `README.md`
        - TODO:
            3.0 User Experience: 3.1 -> 3.6:
            4.0 Design: 4.1 - 4.3
                - Exiting Excalidraw and change design to minimalist
            9.0 Features, Screenshots, Acceptance, Responsiveness
            11.0 Assessments: Credits etc
        - DONE:
          - Section: ✅✅✅
            1.0 Introduction ✅
            2.0 Solution:  Tic Tac Toe: ✅
            3.0 User Experience: 3.1, 3.2: ✅
            5.0 Build:  ✅
            6.0 Code: ✅
                6.0.1 -> 6.0.5✅
                6.1 -> 6.3 ✅
            7.0 Logic:  Code Flow Diagrams to explain Logic.js ✅
            8.0: Testing: 8.1 -> 8.2  ✅
            10.0: Deployment:  10.1 -> 10.4 ✅ ✅
        - `PROJECTS.md`
           - P2 Project criteria re-presented as Definition of Done checklist,
- refactor:
- rename:
- removed:
- fixed:
- logging:
- linted: ✅ Completed 2024/01/22
- edits:
- deploy:
Refs:
-
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@iPoetDev iPoetDev merged commit 973d0ed into main Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant