Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Connections API calls #508

Closed
Bryn72 opened this issue Jan 27, 2024 · 2 comments
Closed

Error in Connections API calls #508

Bryn72 opened this issue Jan 27, 2024 · 2 comments

Comments

@Bryn72
Copy link

Bryn72 commented Jan 27, 2024

I seem to notice that the iRail api Connections doen't care about the results parameter that is passed in the query. It returns all available trainroutes, regardless of the amount specified in the results querystring.

@Bertware Bertware transferred this issue from iRail/iRail-docs Jan 28, 2024
@Bertware
Copy link
Member

This function probably stopped working while we moved between different internal data sources, and has some advantages. It means we can cache more data since requests can't differ on the number of requested results. This also reduces the load we put on the NMBS.

It would be possible to restore this functionality, by fetching all trainroutes then filtering before they are returned in the response. This would mean a response with fewer results is not faster, but it would be smaller.

What would be the use-case for you?

Somewhat relates to #504 .

@Bertware
Copy link
Member

Closed due to inactivity. Reopen if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants