Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two stations renamed in Liège / Luik #134

Closed
miclf opened this issue Sep 4, 2018 · 2 comments
Closed

Two stations renamed in Liège / Luik #134

miclf opened this issue Sep 4, 2018 · 2 comments
Assignees

Comments

@miclf
Copy link
Contributor

miclf commented Sep 4, 2018

Hi there!

Since yesterday SNCB / NMBS changed the name of two stations in Liège / Luik:

  • “Liège-Jonfosse / Luik-Jonfosse” became “Liège-Carré / Luik-Carré”
  • “Liège-Palais / Luik-Paleis” became “Liège-Saint-Lambert / Luik-Sint-Lambertus”

Press release (in French): https://www.belgiantrain.be/fr/about-sncb/news/press-releases/2018/28-08-2018-3
It seems that no press release was issued in other languages.

Wikipedia pages:
FR: Liège-Carré and Liège-Saint-Lambert
NL: Luik-Carré and Luik-Sint-Lambertus

The name of Liège-Palais / Luik-Paleis has already been updated in PR #132 but unfortunately the French name has been set to “Liege-Saint-Lambert”, with a missing grave accent in “Liège”.

Liège-Jonfosse / Luik-Jonfosse has not been updated yet.

I’m not sure if the stations.csv is supposed to be edited manually of if it has to be updated using a different way, so this is why I open an issue instead of directly submitting a pull request. If you tell me it’s safe to update the file, I can make a PR to rename these two stations.

@Bertware Bertware self-assigned this Sep 4, 2018
@Bertware
Copy link
Member

Bertware commented Sep 4, 2018

Thanks for the issue! We noticed the renamed Liège-Palais, but the other one escaped our attention. While we have an automated script to update the stations.csv file, you can safely adjust the names of the station. Names and translations will be kept (which is also the reason the script can't fix these renames (yet)).
Feel free to make a PR, and thanks in advance!

@Bertware
Copy link
Member

Bertware commented Sep 5, 2018

Merged #135 , thanks for opening the issue and your contribution!

@Bertware Bertware closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants