Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy to dev.iscsc.fr workflow #61

Merged
merged 11 commits into from
May 21, 2024
Merged

Add deploy to dev.iscsc.fr workflow #61

merged 11 commits into from
May 21, 2024

Conversation

ctmbl
Copy link
Contributor

@ctmbl ctmbl commented May 17, 2024

completes #53 , see #53 (comment) to understand

see https://dev.iscsc.fr/

  • create a workflow to deploy a PR to this endpoint
  • make the workflow need a maintainer approval (to avoid deployment on EVERY pull request but on-demand) see Introduce a new subdomain dev.iscsc.fr to publish in-development features from opened PRs #53 (comment)
  • update/add GH secrets to take into account the new build artifacts hierarchy
  • carefully check the build folders consistency across host, containers, documentation and GH workflow
  • artificially modify the dev.iscsc.fr webpage to disclaim about its in-devlopment content and give the PR info/commit
  • reate a recurrent workflow that will delete dev.iscsc.fr content and replace it by a default "empty" webpage
  • BUG: use run and not up with docker cvompose to use -e --> fixed b154a02
  • BUG: must overwrite --baseURL to dev.iscsc.fr !! --> fixed b154a02

@ctmbl
Copy link
Contributor Author

ctmbl commented May 17, 2024

originally posted here: #53 (comment)

To require manual approval of the deployment of a PR to dev.iscsc.fr I could have used https://github.com/marketplace/actions/manual-workflow-approval but it creates an issue every time such as liquibase/liquibase#5740 which isn't suitable in our case

I preferred to use the GitHub way with Environments and created a deployment-dev environment whihc requires my approval to allow the workflow to run:

@ctmbl ctmbl changed the title Add a deploy to dev.iscsc.fr workflow Add deploy to dev.iscsc.fr workflow May 21, 2024
@ctmbl ctmbl self-assigned this May 21, 2024
@ctmbl ctmbl added enhancement New feature or request tooling Improvements or additions to tooling, automation, practicality... and removed enhancement New feature or request labels May 21, 2024
@ctmbl ctmbl linked an issue May 21, 2024 that may be closed by this pull request
@ctmbl ctmbl merged commit eadb7b1 into main May 21, 2024
4 of 5 checks passed
@ctmbl ctmbl deleted the deploy-dev-workflow branch May 21, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Improvements or additions to tooling, automation, practicality...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy a dev site
1 participant