Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display east only/west only/all routes #23

Merged
merged 2 commits into from Nov 7, 2018
Merged

Display east only/west only/all routes #23

merged 2 commits into from Nov 7, 2018

Conversation

BQZic
Copy link
Collaborator

@BQZic BQZic commented Nov 6, 2018

No description provided.

quuu
quuu requested changes Nov 6, 2018
View reviewed changes
Copy link
Collaborator

@quuu quuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when only east map is displayed but "East Only" is pressed again? Removing an annotation not there?

@BQZic
Copy link
Collaborator Author

BQZic commented Nov 6, 2018

I think mapview.removeannotation handles that situation, but I do need to check whether an annotation exists. I will modify that!

quuu
quuu approved these changes Nov 7, 2018
View reviewed changes
Copy link
Collaborator

@quuu quuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no conflicts, will revisit implementation later

@quuu quuu merged commit 2f388e4 into master Nov 7, 2018
@BQZic BQZic deleted the frontend branch November 25, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quuu quuu quuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BQZic @quuu