-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StackView Widgets (#45) #346
Conversation
Hi Victor, thank you for the pull request! I think this is a great feature. The StackView worked even better than I expected. I have been testing this on the emulator and I came across two glitches:
|
@iSoron Details of the changes I just pushed:
Please let me know what you think of these points! |
Hi @vyu1, sorry about the long delay. I finally had some time to work on this, and I was able to reduce the flicker problem considerably. It's not perfect, but I think it's good enough. I went ahead and merged your patches into the |
Hey @iSoron, sorry I haven't responded to this message in over a month!! I'm so excited to hear this has been merged in and I appreciate your thanks! Hopefully I can find another thing to work on and contribute to, thanks again 😄 |
I enjoy using the checkmark widget and really like it's transparent design, but having 5-7 checkmark widgets takes up way too much screen space on my home screen. I implemented a StackView style for the existing Checkmark widget. This new feature is related to #45.
To test my changes, place down a checkmark widget and a new
HabitPicker
dialog should appear. This dialog allows you to select up to as many habits as you prefer. If you only select 1, then the app will create the familiar Checkmark widget we have today. If you select multiple, then the app creates a StackView-style Checkmark widget in which you can scroll through the specific habits you selected.There are a few things to be discussed:
I would love any and all feedback!