Fixed bug with implicit conversion of Outcome<TObservation> and Resul…

…t<T, TObservation> when source TObservation type is Unit...

Application/iSynaptic.Commons/Outcome.cs

@@ -310,6 +310,11 @@ public static Outcome<TObservation> ObserveMany<TObservation>(this Outcome<TObse
             return new Outcome<TObservation>(() => new Outcome<TObservation>(self.WasSuccessful, self.Observations.Concat(selector(self.WasSuccessful))));
         }
 
+        public static Outcome<T> Fail<T>(this Outcome<T> @this)
+        {
+            return new Outcome<T>(false, @this.Observations);
+        }
+
         public static Outcome<Unit> FailIf(bool predicate)
         {
             return new Outcome<Unit>(!predicate);

Application/iSynaptic.Commons/Result.cs

@@ -254,7 +254,7 @@ public Outcome<TObservation> ToOutcome()
 
         public static implicit operator Result<T, TObservation>(Result<T, Unit> result)
         {
-            return new Result<T, TObservation>(result.ToMaybe(), new Outcome<TObservation>());
+            return new Result<T, TObservation>(result.ToMaybe(), new Outcome<TObservation>(result.WasSuccessful, null));
         }
 
         public static implicit operator Result<T, TObservation>(Result<Unit, TObservation> result)
@@ -264,7 +264,7 @@ public Outcome<TObservation> ToOutcome()
 
         public static implicit operator Result<T, TObservation>(Result<Unit, Unit> result)
         {
-            return new Result<T, TObservation>();
+            return new Result<T, TObservation>(result.WasSuccessful, null);
         }
     }
 
@@ -528,6 +528,11 @@ public static class Result
             return new Result<T, TObservation>(() => new Result<T, TObservation>(self.ToMaybe(), self.ToOutcome().Combine(outcomes)));
         }
 
+        public static Result<T, TObservation> Fail<T, TObservation>(this Result<T, TObservation> @this)
+        {
+            return new Result<T, TObservation>(@this.ToMaybe(), new Outcome<TObservation>(false, @this.Observations));
+        }
+
         public static Result<Unit, Unit> FailIf(bool predicate)
         {
             return new Result<Unit, Unit>(Maybe.NoValue, Outcome.FailIf(predicate));

CommonAssemblyInfo.cs

@@ -36,5 +36,5 @@
 [assembly: ComVisible(false)]
 [assembly: CLSCompliant(true)]
 
-[assembly: AssemblyVersion("0.4.15.0")]
-[assembly: AssemblyFileVersion("0.4.15.0")]
+[assembly: AssemblyVersion("0.4.16.0")]
+[assembly: AssemblyFileVersion("0.4.16.0")]

Testing/iSynaptic.Commons.UnitTests/OutcomeTests.cs

@@ -21,9 +21,7 @@
 // THE SOFTWARE.
 
 using System;
-using System.Collections.Generic;
 using System.Linq;
-using System.Text;
 using NUnit.Framework;
 
 namespace iSynaptic.Commons
@@ -255,6 +253,13 @@ public void Run_ForcesEvaluation()
             outcome.Run();
             Assert.IsTrue(executed);
         }
+
+        [Test]
+        public void ImplicitConversion_WhenObservationTypeIsUnit_DoesNotLooseFailures()
+        {
+            Outcome<String> outcome = Outcome.Failure();
+            Assert.IsFalse(outcome.WasSuccessful);
+        }
     }
 
     public class Observation

Testing/iSynaptic.Commons.UnitTests/ResultTests.cs

@@ -242,6 +242,16 @@ public void ImplicitConversionOf_ResultUnitAndT_ToAnyOtherResultType()
             Assert.IsTrue(intStringResult.Observations.SequenceEqual(new[]{"Hello, World!"}));
         }
 
+        [Test]
+        public void ImplicitConversion_WhenObservationTypeIsUnit_DoesNotLooseFailures()
+        {
+            Result<int, string> intStringResult = Result.Failure();
+            Assert.IsFalse(intStringResult.WasSuccessful);
+
+            intStringResult = 42.ToResult().Fail();
+            Assert.IsFalse(intStringResult.WasSuccessful);
+        }
+
         [Test]
         public void Success_Default()
         {

Work Items.txt

@@ -1,14 +1,15 @@
 == v0.5 Changes ==
 - Remove ".Commons" from all namespaces
 - Rename Maybe<T> to Optional<T>...
-- Make Outcome eagerly evaluated...
+- Consider making Outcome eagerly evaluated...
 - Consider tying .WasSuccessful to each observation in Outcome<TObservation> and Result<T, TObservation>...
 - Eliminate all optional arguments from methods
 - Change all Guard.NotNull(@this, "@this") calls to Guard.NotNull(@this, "this") - argument name shouldn't have '@' sign
 - Rename Guard to Argument
 - Refactor CompositeDisposable to dispose enlisted items in reverse order...
 - Fix SystemClock to not allow changes to default strategy after prevent is called; disallow returning times that are not in UTC.
 - Evaluate targeting Client profile...
+- Consider better how Unit interacts with Maybe<T>, Outcome<TObservation>, and Result<T, TObservation>
 
 == Potential Future Changes ==
 - Create experimental fork

iSynaptic.Commons.ReleaseNotes.txt

@@ -2,6 +2,14 @@
 RELEASE NOTES: iSynaptic.Commons
 ======================================
 
+==== v0.4.16 (February 6, 2012) ====
+
+---- Features ----
+
+* Fixed bug where failures are lost in implicit conversion to Outcome<TObservation>
+  and Result<T, TObservation> when the source TObservation type is Unit.
+
+
 ==== v0.4.15 (February 4, 2012) ====
 
 ---- Features ----

iSynaptic.Commons.nuspec

@@ -2,7 +2,7 @@
 <package>
   <metadata>
     <id>iSynaptic.Commons</id>
-    <version>0.4.15</version>
+    <version>0.4.16</version>
     <authors>Jordan Terrell</authors>
     <description>Library of common functionality in functional programming style.</description>
     <language>en-US</language>