Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TehanovAnton/hometask-5 #118

Conversation

TehanovAnton
Copy link
Contributor

No description provided.

Copy link

@dmokreckiy dmokreckiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments below

TehanovAnton/hometask-5/hometask Show resolved Hide resolved
TehanovAnton/hometask-5/hometask Show resolved Hide resolved
delete from film f
where (select count(*) from film_category fc where fc.film_id = f.film_id) = 0;

9) select a.first_name

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add last_name

```
language | count
----------------------+-------
English | 949

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have re-seeded DB from dump after deletion. But still valid.

Copy link

@dmokreckiy dmokreckiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Kudos for markdown report.

@TehanovAnton TehanovAnton merged commit 6034cb1 into iTechArt-RubyLab:rubylab-2021-2022 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants