fix: implement uuid parsing according to RFC4122 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 81.18% 81.36% +0.18%
==========================================
Files 59 59
Lines 2998 3027 +29
==========================================
+ Hits 2434 2463 +29
Misses 564 564 ☔ View full report in Codecov by Sentry. |
iTrooz
requested changes
Dec 24, 2023
iTrooz
requested changes
Dec 24, 2023
ju6ge
force-pushed
the
fix/uuid-hard-drive-parsing
branch
from
17b0b7b
to
5bf5443
Compare
iTrooz
changed the title
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to use the efivars variable to read my boot configuration I noticed that the displayed uuid did not match the actual uuid of my EFI partition. After some digging it turned out that the current implementation does not comply with the UEFI Specification for GUID
This PR fixes the parsing and byte serialization. Not sure if there are other parts of the codebase where this might be required as well.