You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
We would like to have a toolbar that contains the items which are visible/hidden based on a specific condition (like the image below). We use the AppUI's Toolbar to make the toolbar but it seems that it still does not support showing/hiding a ToolbarItem with isHidden property set yet.
Note: We have tried to use the ToolbarComposer but it does not meet our use case because it keeps trying to load/display the toolbar items from the UI providers only.
Describe the solution you'd like
Make the Toolbar works similarly to the ToolbarComposer.
Describe alternatives you've considered
We have copied some pieces of code which manage the visibility of the toolbar items from the ToolbarComposer (e.g. copied the hook useToolbarItemSyncEffect, and use some internal APIs like ToolbarItemsChangedArgs, ToolbarItemsManager...) and used them in our code base. It works but we don't think it is a good solution though.
The text was updated successfully, but these errors were encountered:
@GerardasB despite the other work that you'll make regarding #85 I'll take a look into this one, currently, the Conditional** is handled by ToolbarItemsManager, and not in the Toolbar or ToolbarWithOverflow, I think those should handle it as well, so I'll refactor to enable those, which should provide the solution to this issue.
Hi @ezmobivietnam , a fix for this have been provided in 4.4.0 which was released today, the Toolbar component will now correctly handle Conditional props on toolbar items without the need of the ToolbarComposer.
Is your feature request related to a problem? Please describe.
We would like to have a toolbar that contains the items which are visible/hidden based on a specific condition (like the image below). We use the AppUI's Toolbar to make the toolbar but it seems that it still does not support showing/hiding a ToolbarItem with isHidden property set yet.
Note: We have tried to use the ToolbarComposer but it does not meet our use case because it keeps trying to load/display the toolbar items from the UI providers only.
Describe the solution you'd like
Make the Toolbar works similarly to the ToolbarComposer.
Describe alternatives you've considered
We have copied some pieces of code which manage the visibility of the toolbar items from the ToolbarComposer (e.g. copied the hook useToolbarItemSyncEffect, and use some internal APIs like ToolbarItemsChangedArgs, ToolbarItemsManager...) and used them in our code base. It works but we don't think it is a good solution though.
The text was updated successfully, but these errors were encountered: