Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV creation #67

Merged
merged 3 commits into from
May 7, 2024
Merged

Fix CSV creation #67

merged 3 commits into from
May 7, 2024

Conversation

ben-polinsky
Copy link
Collaborator

@ben-polinsky ben-polinsky commented May 6, 2024

Fix CSV creation - since we are currently (under discussion) allowing only public APIs to be extension APIs, that is now hard coded.

Add basic CSV creation test.

Also, fixes an issue:
program.getResolvedModule can return undefined, but we were not expecting that possibility.

@ben-polinsky ben-polinsky merged commit 55b81ba into main May 7, 2024
4 checks passed
@ben-polinsky ben-polinsky deleted the csv-fix-add-test branch May 7, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants