Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleSwitch outline not displayed in child windows #1584

Closed
raplemie opened this issue Sep 20, 2023 · 3 comments · Fixed by #1586
Closed

ToggleSwitch outline not displayed in child windows #1584

raplemie opened this issue Sep 20, 2023 · 3 comments · Fixed by #1586

Comments

@raplemie
Copy link
Contributor

raplemie commented Sep 20, 2023

Describe the bug (actual behavior)

When using suggested style copy method exposed in related thread, the ToggleSwitch outlines are lost.


This looks like a different problem specific to ToggleSwitch. Could you open a new issue for tracking it? I may have an idea what's going wrong.

Originally posted by @mayank99 in #1579 (comment)


Expected behavior

ToggleSwitch behave normally like other components while in a child window, given the copying of style that is working for other components

Reproduction

Link to a minimal repro:
https://codesandbox.io/s/itwinui-react-upgrade-and-popout-forked-5z6mpz?file=/src/App.tsx

Steps to reproduce
  1. When clicking on "Click me", notice that all styles apprear correct, but ToggleSwitch outline is not present

Additional information

@FlyersPh9
Copy link
Collaborator

If I add border-width: 1px; and border-style: solid; in dev tools, it works. Something must be wrong with this line.

@mayank99
Copy link
Contributor

fixed in 2.12.9

@raplemie
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants