Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn test file name changes & test high contrast themes #799

Closed
2 of 3 tasks
FlyersPh9 opened this issue Nov 7, 2022 · 2 comments
Closed
2 of 3 tasks

yarn test file name changes & test high contrast themes #799

FlyersPh9 opened this issue Nov 7, 2022 · 2 comments
Assignees
@elephantcatdog
Labels
enhancement New feature or request

Comments

@FlyersPh9
Copy link
Collaborator

FlyersPh9 commented Nov 7, 2022 •
edited by AdamMeza-Bentley

  • Tests currently only check light & dark theme, we should also check against both high contrast themes.
  • Tests should also check against forced-colors mode.
  • Image file names should all be prefixed with theme name. Currently only dark theme has a prefix which screws up alphabetical sorting of the test images.
@FlyersPh9 FlyersPh9 added the enhancement New feature or request label Nov 7, 2022
@FlyersPh9 FlyersPh9 linked a pull request Nov 8, 2022 that will close this issue
Leah/update visual testing #801
Closed
@elephantcatdog elephantcatdog linked a pull request Nov 9, 2022 that will close this issue
chore: Update visual testing #802
Closed
@elephantcatdog elephantcatdog removed their assignment Nov 28, 2022
@elephantcatdog
Copy link
Contributor

elephantcatdog commented Nov 28, 2022 •
edited

1 & 3 were completed in #822

@FlyersPh9 FlyersPh9 changed the title yarn test enhancements yarn test file name changes & test high contrast themes Dec 5, 2022
@FlyersPh9 FlyersPh9 mentioned this issue Dec 5, 2022
Open
@FlyersPh9
Copy link
Collaborator Author

Changing this issue to only address what were items 1 & 3. Item 2 is now logged as #832 .

mayank99 added a commit that referenced this issue Dec 19, 2022
@mayank99
docs: Fix broken links in README (#799)
c7b6a97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elephantcatdog elephantcatdog

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Leah/update visual testing iTwin/iTwinUI
chore: Update visual testing iTwin/iTwinUI
2 participants
@FlyersPh9 @elephantcatdog