Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding input container #1355

Merged
merged 162 commits into from Aug 30, 2023
Merged

Rebuilding input container #1355

merged 162 commits into from Aug 30, 2023

Conversation

gretanausedaite
Copy link
Contributor

@gretanausedaite gretanausedaite commented Jun 14, 2023

Changes

React:

InputFlexContainer:

  • Add ‘size’ prop

InputContainer:

  • Using InputGrid css
  • Using new StatusMessage component
  • Removed ‘isIconInline’ prop;

Icon:

  • Added ‘padded’ prop (false by default)

TransferList:

  • Remove 'iui-transfer-list-listbox-label' class
  • Using simple Label

Textarea:

  • Added ‘status’ prop

DatePickerInput:

  • Using InputGrid, Label, InputWithDecorations

StatusMessage:

  • Added wrapper class ‘iui-status-message’
  • Added ‘iconProps’ and ‘contentProps’

Select:

  • Added ‘status’ prop
  • Removed click ripple effect animation from caret down.

LabeledTextarea:

  • Added ‘wrapperProps’, ‘labelProps’’, ‘messageContentProps’, ‘iconProps’;
  • Using InputGrid and InputWithDecorations;
  • Removed ‘textareaClassName’ and ‘textareaStyle’ props, Users can pass custom styling to textarea using classname and style props

LabeledSelect:

  • Added ‘wrapperProps’, ‘labelProps’’, ‘messageContentProps’, ‘messageIconProps’;
  • Using InputGrid;
  • Removed ‘selectClassName’, ‘selectStyle’ props. Users can pass custom styling to select using classname and style props;

LabeledInput:

  • Added ‘messageContentProps’, iconProps, labelProps, inputWrapperPRops;
  • Removed ‘inputClassName’ and ‘inputStyle’ props;
  • Using InputGrid and InputWithDecorations;

Label:

  • Added disabled prop;

InputWithDecorations:

  • New component
  • Subcomponents: Input and Button.

InputGroup:

  • Added labelProps, messageProps and innerProps;
  • Using InputGrid

InputGrid:

  • New component

Input:

  • Add status prop;

ComboBox:

  • Removed functionality to close menu on caret down click;

ColorInputPanel:

  • Simplified DOM structure;

CSS:

Icon:

  • Added padded Icon styling using data-iui-padded attribute

TransferList:

  • Removed iui-transfer-list-listbox-label

ColumnFIlter:

  • Updated to use input-grid

StatusMessage:

  • Added wrapper class iui-status-message

Select:

  • Added status colouring

NonIdealState:

  • Updated to use input-grid

InputContainer:

  • Removed mixins;
  • Removed iui-input-container class;
  • Added iui-input-grid, iui-input-label, iui-input-group-wrapper, ‘iui-input-group’ classes;
  • Updated input-flex-container to include textarea;

Input:

  • Added status styling
  • Removed input-with-icon and iui-end-icon mixing;

Informationpanel:

  • Updated to not use input-label-inline mixin;

ButtonGroup:

  • Updated selectors to not use input-container and use input-grid;

Testing

  • Visual CSS - InputGrid html added; InputWithDecorations is tested in SearchBox tests.
  • Visual React - InputGrid and InputWithDecorations stories added
  • Unit

Docs

@gretanausedaite gretanausedaite self-assigned this Jun 14, 2023
@gretanausedaite gretanausedaite added this to the React 3.0 milestone Jun 14, 2023
@mayank99 mayank99 mentioned this pull request Jun 14, 2023
24 tasks
@gretanausedaite

This comment was marked as resolved.

@gretanausedaite gretanausedaite marked this pull request as ready for review July 5, 2023 11:49
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure visual tests pass before merging. The react ones might need to be approved a few times (and you can temporarily disable retries to make it faster)

examples/Input.button.tsx Outdated Show resolved Hide resolved
@gretanausedaite gretanausedaite merged commit 31fe9c9 into dev Aug 30, 2023
14 of 16 checks passed
@gretanausedaite gretanausedaite deleted the greta/input-work branch August 30, 2023 14:48
mayank99 added a commit that referenced this pull request Aug 30, 2023
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants